Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127953003: Remove viewmatrix from GrGeometryProcessor base class (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove viewmatrix from GrGeometryProcessor base class BUG=skia: Committed: https://skia.googlesource.com/skia/+/e578a95d3ab16544794b94da4e7ae13fc2ce6244

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -70 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 4 chunks +7 lines, -3 lines 1 comment Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 10 chunks +11 lines, -13 lines 1 comment Download
M src/gpu/GrPathProcessor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 6 chunks +6 lines, -0 lines 3 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +15 lines, -10 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 8 chunks +4 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 6 chunks +6 lines, -0 lines 3 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 9 chunks +14 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +1 line, -1 line 1 comment Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-14 15:55:40 UTC) #2
robertphillips
https://codereview.chromium.org/1127953003/diff/1/src/gpu/gl/GrGLGeometryProcessor.h File src/gpu/gl/GrGLGeometryProcessor.h (right): https://codereview.chromium.org/1127953003/diff/1/src/gpu/gl/GrGLGeometryProcessor.h#newcode56 src/gpu/gl/GrGLGeometryProcessor.h:56: const char* posName, Hmmm
5 years, 7 months ago (2015-05-14 16:20:10 UTC) #3
robertphillips
lgtm + questions https://codereview.chromium.org/1127953003/diff/1/src/gpu/GrDefaultGeoProcFactory.cpp File src/gpu/GrDefaultGeoProcFactory.cpp (right): https://codereview.chromium.org/1127953003/diff/1/src/gpu/GrDefaultGeoProcFactory.cpp#newcode214 src/gpu/GrDefaultGeoProcFactory.cpp:214: GrColor fColor; Can this be const? ...
5 years, 7 months ago (2015-05-14 16:35:25 UTC) #4
joshualitt
On 2015/05/14 16:35:25, robertphillips wrote: > lgtm + questions > > https://codereview.chromium.org/1127953003/diff/1/src/gpu/GrDefaultGeoProcFactory.cpp > File src/gpu/GrDefaultGeoProcFactory.cpp ...
5 years, 7 months ago (2015-05-14 17:02:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127953003/1
5 years, 7 months ago (2015-05-14 17:02:35 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 17:09:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e578a95d3ab16544794b94da4e7ae13fc2ce6244

Powered by Google App Engine
This is Rietveld 408576698