Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/gpu/effects/GrBezierEffect.h

Issue 1127953003: Remove viewmatrix from GrGeometryProcessor base class (Closed) Base URL: https://skia.googlesource.com/skia.git@cleanup3
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrBezierEffect_DEFINED 8 #ifndef GrBezierEffect_DEFINED
9 #define GrBezierEffect_DEFINED 9 #define GrBezierEffect_DEFINED
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 virtual ~GrConicEffect(); 91 virtual ~GrConicEffect();
92 92
93 const char* name() const override { return "Conic"; } 93 const char* name() const override { return "Conic"; }
94 94
95 inline const Attribute* inPosition() const { return fInPosition; } 95 inline const Attribute* inPosition() const { return fInPosition; }
96 inline const Attribute* inConicCoeffs() const { return fInConicCoeffs; } 96 inline const Attribute* inConicCoeffs() const { return fInConicCoeffs; }
97 inline bool isAntiAliased() const { return GrProcessorEdgeTypeIsAA(fEdgeType ); } 97 inline bool isAntiAliased() const { return GrProcessorEdgeTypeIsAA(fEdgeType ); }
98 inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); } 98 inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); }
99 inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; } 99 inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; }
100 GrColor color() const { return fColor; } 100 GrColor color() const { return fColor; }
101 const SkMatrix& viewMatrix() const { return fViewMatrix; }
101 102
102 virtual void getGLProcessorKey(const GrBatchTracker& bt, 103 virtual void getGLProcessorKey(const GrBatchTracker& bt,
103 const GrGLSLCaps& caps, 104 const GrGLSLCaps& caps,
104 GrProcessorKeyBuilder* b) const override; 105 GrProcessorKeyBuilder* b) const override;
105 106
106 virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt, 107 virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt,
107 const GrGLSLCaps&) const ov erride; 108 const GrGLSLCaps&) const ov erride;
108 109
109 void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override ; 110 void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override ;
110 111
111 private: 112 private:
112 GrConicEffect(GrColor, const SkMatrix& viewMatrix, uint8_t coverage, GrPrimi tiveEdgeType, 113 GrConicEffect(GrColor, const SkMatrix& viewMatrix, uint8_t coverage, GrPrimi tiveEdgeType,
113 const SkMatrix& localMatrix); 114 const SkMatrix& localMatrix);
114 115
115 GrColor fColor; 116 GrColor fColor;
robertphillips 2015/05/14 16:35:24 const ?
117 SkMatrix fViewMatrix;
116 uint8_t fCoverageScale; 118 uint8_t fCoverageScale;
117 GrPrimitiveEdgeType fEdgeType; 119 GrPrimitiveEdgeType fEdgeType;
118 const Attribute* fInPosition; 120 const Attribute* fInPosition;
119 const Attribute* fInConicCoeffs; 121 const Attribute* fInConicCoeffs;
120 122
121 GR_DECLARE_GEOMETRY_PROCESSOR_TEST; 123 GR_DECLARE_GEOMETRY_PROCESSOR_TEST;
122 124
123 typedef GrGeometryProcessor INHERITED; 125 typedef GrGeometryProcessor INHERITED;
124 }; 126 };
125 127
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 virtual ~GrQuadEffect(); 171 virtual ~GrQuadEffect();
170 172
171 const char* name() const override { return "Quad"; } 173 const char* name() const override { return "Quad"; }
172 174
173 inline const Attribute* inPosition() const { return fInPosition; } 175 inline const Attribute* inPosition() const { return fInPosition; }
174 inline const Attribute* inHairQuadEdge() const { return fInHairQuadEdge; } 176 inline const Attribute* inHairQuadEdge() const { return fInHairQuadEdge; }
175 inline bool isAntiAliased() const { return GrProcessorEdgeTypeIsAA(fEdgeType ); } 177 inline bool isAntiAliased() const { return GrProcessorEdgeTypeIsAA(fEdgeType ); }
176 inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); } 178 inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); }
177 inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; } 179 inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; }
178 GrColor color() const { return fColor; } 180 GrColor color() const { return fColor; }
181 const SkMatrix& viewMatrix() const { return fViewMatrix; }
179 182
180 virtual void getGLProcessorKey(const GrBatchTracker& bt, 183 virtual void getGLProcessorKey(const GrBatchTracker& bt,
181 const GrGLSLCaps& caps, 184 const GrGLSLCaps& caps,
182 GrProcessorKeyBuilder* b) const override; 185 GrProcessorKeyBuilder* b) const override;
183 186
184 virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt, 187 virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt,
185 const GrGLSLCaps&) const ov erride; 188 const GrGLSLCaps&) const ov erride;
186 189
187 void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override ; 190 void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override ;
188 191
189 private: 192 private:
190 GrQuadEffect(GrColor, const SkMatrix& viewMatrix, uint8_t coverage, GrPrimit iveEdgeType, 193 GrQuadEffect(GrColor, const SkMatrix& viewMatrix, uint8_t coverage, GrPrimit iveEdgeType,
191 const SkMatrix& localMatrix); 194 const SkMatrix& localMatrix);
192 195
193 GrColor fColor; 196 GrColor fColor;
robertphillips 2015/05/14 16:35:24 const ?
197 SkMatrix fViewMatrix;
194 uint8_t fCoverageScale; 198 uint8_t fCoverageScale;
195 GrPrimitiveEdgeType fEdgeType; 199 GrPrimitiveEdgeType fEdgeType;
196 const Attribute* fInPosition; 200 const Attribute* fInPosition;
197 const Attribute* fInHairQuadEdge; 201 const Attribute* fInHairQuadEdge;
198 202
199 GR_DECLARE_GEOMETRY_PROCESSOR_TEST; 203 GR_DECLARE_GEOMETRY_PROCESSOR_TEST;
200 204
201 typedef GrGeometryProcessor INHERITED; 205 typedef GrGeometryProcessor INHERITED;
202 }; 206 };
203 207
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 virtual ~GrCubicEffect(); 247 virtual ~GrCubicEffect();
244 248
245 const char* name() const override { return "Cubic"; } 249 const char* name() const override { return "Cubic"; }
246 250
247 inline const Attribute* inPosition() const { return fInPosition; } 251 inline const Attribute* inPosition() const { return fInPosition; }
248 inline const Attribute* inCubicCoeffs() const { return fInCubicCoeffs; } 252 inline const Attribute* inCubicCoeffs() const { return fInCubicCoeffs; }
249 inline bool isAntiAliased() const { return GrProcessorEdgeTypeIsAA(fEdgeType ); } 253 inline bool isAntiAliased() const { return GrProcessorEdgeTypeIsAA(fEdgeType ); }
250 inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); } 254 inline bool isFilled() const { return GrProcessorEdgeTypeIsFill(fEdgeType); }
251 inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; } 255 inline GrPrimitiveEdgeType getEdgeType() const { return fEdgeType; }
252 GrColor color() const { return fColor; } 256 GrColor color() const { return fColor; }
257 const SkMatrix& viewMatrix() const { return fViewMatrix; }
253 258
254 virtual void getGLProcessorKey(const GrBatchTracker& bt, 259 virtual void getGLProcessorKey(const GrBatchTracker& bt,
255 const GrGLSLCaps& caps, 260 const GrGLSLCaps& caps,
256 GrProcessorKeyBuilder* b) const override; 261 GrProcessorKeyBuilder* b) const override;
257 262
258 virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt, 263 virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt,
259 const GrGLSLCaps&) const ov erride; 264 const GrGLSLCaps&) const ov erride;
260 265
261 void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override ; 266 void initBatchTracker(GrBatchTracker*, const GrPipelineInfo&) const override ;
262 267
263 private: 268 private:
264 GrCubicEffect(GrColor, const SkMatrix& viewMatrix, GrPrimitiveEdgeType); 269 GrCubicEffect(GrColor, const SkMatrix& viewMatrix, GrPrimitiveEdgeType);
265 270
266 GrColor fColor; 271 GrColor fColor;
robertphillips 2015/05/14 16:35:24 const ?
272 SkMatrix fViewMatrix;
267 GrPrimitiveEdgeType fEdgeType; 273 GrPrimitiveEdgeType fEdgeType;
268 const Attribute* fInPosition; 274 const Attribute* fInPosition;
269 const Attribute* fInCubicCoeffs; 275 const Attribute* fInCubicCoeffs;
270 276
271 GR_DECLARE_GEOMETRY_PROCESSOR_TEST; 277 GR_DECLARE_GEOMETRY_PROCESSOR_TEST;
272 278
273 typedef GrGeometryProcessor INHERITED; 279 typedef GrGeometryProcessor INHERITED;
274 }; 280 };
275 281
276 #endif 282 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698