src/gpu/gl/GrGLGeometryProcessor.h - Issue 1127953003: Remove viewmatrix from GrGeometryProcessor base class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLGeometryProcessor.h

Issue 1127953003: Remove viewmatrix from GrGeometryProcessor base class (Closed) Base URL: https://skia.googlesource.com/skia.git@cleanup3

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGLGeometryProcessor.h

diff --git a/src/gpu/gl/GrGLGeometryProcessor.h b/src/gpu/gl/GrGLGeometryProcessor.h

index 45dd177beb4991bfefdb0cbf23f44e8bb915d865..49ccb8b15cdbdd0df7a4e934778c147a85bd5fb0 100644

--- a/src/gpu/gl/GrGLGeometryProcessor.h

+++ b/src/gpu/gl/GrGLGeometryProcessor.h

@@ -54,7 +54,7 @@ protected:

void setupPosition(GrGLGPBuilder* pb,

GrGPArgs* gpArgs,

const char* posName,

robertphillips 2015/05/14 16:20:10 Hmmm

- const SkMatrix& mat);

+ const SkMatrix& mat = SkMatrix::I());

static uint32_t ComputePosKey(const SkMatrix& mat) {

if (mat.isIdentity()) {