net/http/http_stream_factory_impl_request.h - Issue 1127623005: Gather metrics classifying the cause of the TLS fallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request.h

Issue 1127623005: Gather metrics classifying the cause of the TLS fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-required

Patch Set: rsleevi comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_request.h

diff --git a/net/http/http_stream_factory_impl_request.h b/net/http/http_stream_factory_impl_request.h

index 7bc41afc0b0016790e37410fd446a6b12e5ab0bb..2244253afd94a8c5bbcf51bc1d4891fc691c9d69 100644

--- a/net/http/http_stream_factory_impl_request.h

+++ b/net/http/http_stream_factory_impl_request.h

@@ -12,6 +12,7 @@

#include "net/socket/connection_attempts.h"

#include "net/socket/ssl_client_socket.h"

#include "net/spdy/spdy_session_key.h"

+#include "net/ssl/ssl_failure_state.h"

#include "url/gurl.h"

namespace net {

@@ -81,7 +82,10 @@ class HttpStreamFactoryImpl::Request : public HttpStreamRequest {

const SSLConfig& used_ssl_config,

const ProxyInfo& used_proxy_info,

WebSocketHandshakeStreamBase* stream);

- void OnStreamFailed(Job* job, int status, const SSLConfig& used_ssl_config);

+ void OnStreamFailed(Job* job,

+ int status,

+ const SSLConfig& used_ssl_config,

+ SSLFailureState ssl_failure_state);

void OnCertificateError(Job* job,

int status,

const SSLConfig& used_ssl_config,

« net/http/http_network_transaction.cc ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_request.cc » ('j') | net/ssl/ssl_failure_state.h » ('J')