Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2047)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 1127623005: Gather metrics classifying the cause of the TLS fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-required
Patch Set: rsleevi comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 1172bf1f6dcd3d1f649322cf15b925dcb1ea5c5f..13bc4002f34d6a1035c07b532d6f574c77724260 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -40,6 +40,7 @@
#include "net/spdy/spdy_session.h"
#include "net/spdy/spdy_session_pool.h"
#include "net/ssl/ssl_cert_request_info.h"
+#include "net/ssl/ssl_failure_state.h"
namespace net {
@@ -364,10 +365,14 @@ void HttpStreamFactoryImpl::Job::OnStreamFailedCallback(int result) {
MaybeCopyConnectionAttemptsFromClientSocketHandleToRequest();
- if (IsOrphaned())
+ if (IsOrphaned()) {
stream_factory_->OnOrphanedJobComplete(this);
- else
- request_->OnStreamFailed(this, result, server_ssl_config_);
+ } else {
+ SSLFailureState ssl_failure_state =
+ connection_ ? connection_->ssl_failure_state() : kSSLFailureNone;
+ request_->OnStreamFailed(this, result, server_ssl_config_,
+ ssl_failure_state);
+ }
// |this| may be deleted after this call.
}

Powered by Google App Engine
This is Rietveld 408576698