net/http/http_stream_factory_impl_request.cc - Issue 1127623005: Gather metrics classifying the cause of the TLS fallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_request.cc

Issue 1127623005: Gather metrics classifying the cause of the TLS fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-required

Patch Set: rsleevi comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_network_transaction.cc ('K') | « net/http/http_stream_factory_impl_request.h ('k') | net/http/http_stream_factory_impl_request_unittest.cc » ('j') | net/ssl/ssl_failure_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_impl_request.cc

diff --git a/net/http/http_stream_factory_impl_request.cc b/net/http/http_stream_factory_impl_request.cc

index d8a4b5b6bd9e3447b51f80bf86fad2aab0478f62..53548b1254fbf0706ca1c177bac9a57264f6bd17 100644

--- a/net/http/http_stream_factory_impl_request.cc

+++ b/net/http/http_stream_factory_impl_request.cc

@@ -116,7 +116,8 @@ void HttpStreamFactoryImpl::Request::OnWebSocketHandshakeStreamReady(

void HttpStreamFactoryImpl::Request::OnStreamFailed(

Job* job,

int status,

- const SSLConfig& used_ssl_config) {

+ const SSLConfig& used_ssl_config,

+ SSLFailureState ssl_failure_state) {

DCHECK_NE(OK, status);

DCHECK(job);

if (!bound_job_.get()) {

@@ -139,7 +140,7 @@ void HttpStreamFactoryImpl::Request::OnStreamFailed(

} else {

DCHECK(jobs_.empty());

}

- delegate_->OnStreamFailed(status, used_ssl_config);

+ delegate_->OnStreamFailed(status, used_ssl_config, ssl_failure_state);

}

void HttpStreamFactoryImpl::Request::OnCertificateError(