Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 1127313003: Revert of cc: Adding BeginFrameTracker object and removing Now() from LTHI. (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, simonhong
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Adding BeginFrameTracker object and removing Now() from LTHI. (patchset #17 id:320001 of https://codereview.chromium.org/787763006/) Reason for revert: May have caused Instrumentation test AndroidWebViewTest failures. This is a speculative revert; I will re-land if nothing gets fixed. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27762/steps/Instrumentation%20test%20AndroidWebViewTest/logs/stdio failures: org.chromium.android_webview.test.AndroidScrollIntegrationTest#testFlingScrollOnPopup org.chromium.android_webview.test.PopupWindowTest#testOnPageFinishedCalledOnDomModificationAfterNavigation org.chromium.android_webview.test.PopupWindowTest#testPopupWindow org.chromium.android_webview.test.PostMessageTest#testPostMessageToIframeInsidePopup Original issue's description: > cc: Adding BeginFrameTracker object and removing Now() from LTHI. > > **Sheriffs**: If this patch is making a test flaky / fail, > then the test was already broken and this just makes the > problem visible. > > This patch reduces the jitter in LTHI's animation time to > be identical to the vsync jitter rather than being affected > by the system load and OS scheduling delays. > > BeginFrameTracker uses DCHECKs and TRACE_EVENT to strictly > track how the BeginFrameArgs are used throughout the LTHI. > Using this information incorrect usage of Now() has been > eliminated. Methods which violate correct usage of > BeginFrameArgs are now clearly marked to prevent > regressions. > > BUG=346230 > > Committed: https://crrev.com/ce2671bf523d439ed7db7a606e871ca0416ef7a6 > Cr-Commit-Position: refs/heads/master@{#328911} TBR=brianderson@chromium.org,skyostil@chromium.org,sunnyps@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346230 Committed: https://crrev.com/f1a56b752fcac1a81dc86faff5840486be0cf709 Cr-Commit-Position: refs/heads/master@{#328937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -321 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D cc/scheduler/begin_frame_tracker.h View 1 chunk +0 lines, -97 lines 0 comments Download
D cc/scheduler/begin_frame_tracker.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M cc/scheduler/scheduler.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.cc View 11 chunks +48 lines, -38 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M cc/test/scheduler_test_common.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 4 chunks +8 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 8 chunks +24 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +0 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kunihiko Sakamoto
Created Revert of cc: Adding BeginFrameTracker object and removing Now() from LTHI.
5 years, 7 months ago (2015-05-08 08:13:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313003/1
5 years, 7 months ago (2015-05-08 08:14:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 08:15:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1a56b752fcac1a81dc86faff5840486be0cf709 Cr-Commit-Position: refs/heads/master@{#328937}
5 years, 7 months ago (2015-05-08 08:16:07 UTC) #4
Kunihiko Sakamoto
5 years, 7 months ago (2015-05-08 09:49:33 UTC) #5
Message was sent while issue was closed.
This revert appears to have fixed the test failures.

Powered by Google App Engine
This is Rietveld 408576698