Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1127283002: Revert of Fire AX notifications on list box options. (Closed)

Created:
5 years, 7 months ago by mark a. foltz
Modified:
5 years, 7 months ago
CC:
aboxhall, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, nektarios, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@menu_list_more
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fire AX notifications on list box options. (patchset #7 id:120001 of https://codereview.chromium.org/1034493005/) Reason for revert: Suspect as cause of #1 crash in Windows canaries 44.0.2392.0 and 44.0.2393.0 BUG=484642 Original issue's description: > Fire AX notifications on list box options. > > Previously we just sent a single notification on the > list box when the selection changed, now we send > separate notifications on each option that changes > state too. > > BUG=323462 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192997 TBR=mkwst@chromium.org,je_julie.kim@samsung.com,tkent@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=323462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -155 lines) Patch
D LayoutTests/accessibility/listbox-focus.html View 1 chunk +0 lines, -45 lines 0 comments Download
M LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/AXObjectCache.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXListBox.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/accessibility/AXListBox.cpp View 3 chunks +0 lines, -41 lines 0 comments Download
M Source/modules/accessibility/AXListBoxOption.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 4 chunks +16 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mark a. foltz
Created Revert of Fire AX notifications on list box options.
5 years, 7 months ago (2015-05-06 22:25:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127283002/1
5 years, 7 months ago (2015-05-06 22:25:46 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLSelectElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 7 months ago (2015-05-06 22:26:26 UTC) #4
dmazzoni
5 years, 7 months ago (2015-05-06 22:30:34 UTC) #6
Other changes have landed on top of this one, reverting it will be nontrivial.

This is a one-line fix, let me fix it with a null check rather than a revert.

Powered by Google App Engine
This is Rietveld 408576698