Source/modules/accessibility/AXListBoxOption.h - Issue 1127283002: Revert of Fire AX notifications on list box options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXListBoxOption.h

Issue 1127283002: Revert of Fire AX notifications on list box options. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menu_list_more

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXListBoxOption.h

diff --git a/Source/modules/accessibility/AXListBoxOption.h b/Source/modules/accessibility/AXListBoxOption.h

index 9ce33ad458e292784138d36b3c907895a232f3ec..69f0917fc5019877889fe87f56a4ad84c6043183 100644

--- a/Source/modules/accessibility/AXListBoxOption.h

+++ b/Source/modules/accessibility/AXListBoxOption.h

@@ -47,7 +47,6 @@

static PassRefPtr<AXListBoxOption> create(LayoutObject*, AXObjectCacheImpl*);

virtual ~AXListBoxOption();

- virtual bool isAXListBoxOption() const override { return true; }

virtual AccessibilityRole roleValue() const override;

virtual bool isSelected() const override;

virtual bool isEnabled() const override;

@@ -58,6 +57,7 @@

virtual String title(TextUnderElementMode) const override { return String(); }

private:

+ virtual bool isListBoxOption() const override { return true; }

virtual bool canHaveChildren() const override { return false; }

virtual bool computeAccessibilityIsIgnored() const override;

@@ -66,7 +66,7 @@

AXObject* listBoxOptionAXObject(HTMLElement*) const;

};

-DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isAXListBoxOption());

+DEFINE_AX_OBJECT_TYPE_CASTS(AXListBoxOption, isListBoxOption());

} // namespace blink

« no previous file with comments | « Source/modules/accessibility/AXListBox.cpp ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »