Issue 1127273010: (Temporarily?) disable building JS targets on mac hosts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127273010: (Temporarily?) disable building JS targets on mac hosts (Closed)

Created:
5 years, 7 months ago by jamesr

Modified:
5 years, 7 months ago

Reviewers:
cdotstout

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

(Temporarily?) disable building JS targets on mac hosts We can't currently build V8 on a mac host targetting Android since the v8 snapshot creation step requires a 32 bit host toolchain to target a 32 bit target and we don't have a 32 bit host toolchain configured (yet). Disable for now. R=cstout@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fa50ab665bdfb3f451282868e7986f8e51314e13

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -8 lines)			Patch
M	mojo/BUILD.gn	View	3 chunks	+10 lines, -3 lines	0 comments	Download
M	mojo/public/tools/download_network_service.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	services/BUILD.gn	View	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

5 years, 7 months ago (2015-05-07 22:35:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa50ab665bdfb3f451282868e7986f8e51314e13 (presubmit successful).

Expand Messages | Collapse Messages