Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: services/BUILD.gn

Issue 1127273010: (Temporarily?) disable building JS targets on mac hosts (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/download_network_service.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/BUILD.gn
diff --git a/services/BUILD.gn b/services/BUILD.gn
index 81c59ab7a12781c6d3b2795e998d7d208eab9cb0..ef4503164449a5c7b79ee9b08bb23d40e168cc52 100644
--- a/services/BUILD.gn
+++ b/services/BUILD.gn
@@ -13,7 +13,6 @@ group("services") {
"//services/gles2:lib",
"//services/http_server",
"//services/icu_data",
- "//services/js",
"//services/kiosk_wm",
"//services/native_viewport",
"//services/reaper",
@@ -37,4 +36,10 @@ group("services") {
if (is_linux) {
deps += [ "//services/python" ]
}
+
+ # TODO(jamesr): We only support building V8 snapshot data on a linux host since it
+ # needs a 32 bit toolchain and we don't have one configured for mac hosts.
+ if (host_os == "linux") {
+ deps += [ "//services/js" ]
+ }
}
« no previous file with comments | « mojo/public/tools/download_network_service.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698