Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: mojo/BUILD.gn

Issue 1127273010: (Temporarily?) disable building JS targets on mac hosts (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/tools/download_network_service.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/BUILD.gn
diff --git a/mojo/BUILD.gn b/mojo/BUILD.gn
index 6d5c04b5ef810e9fe29bcfd99cf885f89a45c5bf..d4ac711a4dbeaab389053184b8ca364621686889 100644
--- a/mojo/BUILD.gn
+++ b/mojo/BUILD.gn
@@ -53,7 +53,6 @@ group("tests") {
deps = [
"//mojo/common:mojo_common_unittests",
"//mojo/converters/surfaces/tests:mojo_surfaces_lib_unittests",
- "//mojo/edk/js:tests",
"//mojo/edk/system:tests",
"//mojo/edk/test:public_tests",
"//mojo/dart/embedder/test:dart_unittests",
@@ -65,8 +64,6 @@ group("tests") {
"//services/dart/dart_apptests",
"//services/files:apptests",
"//services/http_server:apptests",
- "//services/js:js_apptests",
- "//services/js:js_services_unittests",
"//services/reaper:tests",
"//services/url_response_disk_cache:tests",
"//services/view_manager:mojo_view_manager_client_apptests",
@@ -85,6 +82,16 @@ group("tests") {
]
}
+ # TODO(jamesr): We only support building V8 snapshot data on a linux host since it
+ # needs a 32 bit toolchain and we don't have one configured for mac hosts.
+ if (host_os == "linux") {
+ deps += [
+ "//mojo/edk/js:tests",
+ "//services/js:js_apptests",
+ "//services/js:js_services_unittests",
+ ]
+ }
+
if (mojo_use_prebuilt_network_service) {
deps += [ "//mojo/public/tools:copy_network_service_apptests" ]
}
« no previous file with comments | « no previous file | mojo/public/tools/download_network_service.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698