Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1127273007: Iterate over instanced draws in GrGpu rather than above GrBatchTarget (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Iterate over instanced draws in GrGpu rather than above GrBatchTarget Committed: https://skia.googlesource.com/skia/+/e64eb570a5b9480bc24d0656ccabcff1ab13a229

Patch Set 1 #

Patch Set 2 : fixed #

Patch Set 3 : save files #

Patch Set 4 : shut clang up #

Patch Set 5 : remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -139 lines) Patch
M gm/beziereffects.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 3 chunks +19 lines, -29 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrBatch.h View 1 3 chunks +4 lines, -8 lines 0 comments Download
M src/gpu/GrBatch.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrVertices.h View 1 2 3 4 4 chunks +71 lines, -53 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127273007/40001
5 years, 7 months ago (2015-05-07 17:44:43 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-07 17:44:44 UTC) #3
joshualitt
On 2015/05/07 17:44:44, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 7 months ago (2015-05-07 17:45:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/919)
5 years, 7 months ago (2015-05-07 17:46:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127273007/60001
5 years, 7 months ago (2015-05-07 17:53:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/924)
5 years, 7 months ago (2015-05-07 17:58:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127273007/80001
5 years, 7 months ago (2015-05-07 18:00:19 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 18:36:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e64eb570a5b9480bc24d0656ccabcff1ab13a229

Powered by Google App Engine
This is Rietveld 408576698