Remove ICS support from build/android/pylib/

Remove ICS support from build/android/pylib/

BUG=473837
Committed: https://crrev.com/59c8117b4fa8d32377ff70fa25e2f15304e386f3
Cr-Commit-Position: refs/heads/master@{#329224}

[aurimas (slooooooooow), 2015-05-11 17:32:55]

aurimas@chromium.org changed reviewers:
+ jbudorick@chromium.org

[aurimas (slooooooooow), 2015-05-11 17:32:56]

PTAL

[jbudorick, 2015-05-11 17:38:36]

https://codereview.chromium.org/1127133004/diff/1/build/android/pylib/device/...
File build/android/pylib/device/device_utils_test.py (left):

https://codereview.chromium.org/1127133004/diff/1/build/android/pylib/device/...
build/android/pylib/device/device_utils_test.py:742: def
testGetDevicePieWrapper_ics(self):
Removing the test but not the code isn't quite right. I'd prefer we either leave
this as-is or remove DeviceUtils.GetDevicePieWrapper entirely, as deprecating
ICS means it's obsolete.

[aurimas (slooooooooow), 2015-05-11 17:45:23]

Please take another look.

https://codereview.chromium.org/1127133004/diff/20001/build/android/provision...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/provision...
build/android/provision_devices.py:250: ['', '/data/local/tmp/adb_reboot'],
Can I remove the ''?

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/gte...
File build/android/pylib/gtest/test_package_exe.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/gte...
build/android/pylib/gtest/test_package_exe.py:119: for wrapper in
(self.tool.GetTestWrapper()):
Should I simplify this remove this for loop?

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/md5sum.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/md5sum.py:71: device_pie_wrapper='',
Can I remove this completely?

[jbudorick, 2015-05-11 17:49:42]

lgtm after your suggested changes

https://codereview.chromium.org/1127133004/diff/20001/build/android/provision...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/provision...
build/android/provision_devices.py:250: ['', '/data/local/tmp/adb_reboot'],
On 2015/05/11 17:45:23, aurimas wrote:
> Can I remove the ''?

Yeah, this can just be ['/data/local/tmp/adb_reboot'] now.

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/gte...
File build/android/pylib/gtest/test_package_exe.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/gte...
build/android/pylib/gtest/test_package_exe.py:119: for wrapper in
(self.tool.GetTestWrapper()):
On 2015/05/11 17:45:23, aurimas wrote:
> Should I simplify this remove this for loop?

Yeah, that'd be great.

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/md5sum.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/md5sum.py:71: device_pie_wrapper='',
On 2015/05/11 17:45:23, aurimas wrote:
> Can I remove this completely?

Yep.

[aurimas (slooooooooow), 2015-05-11 18:36:33]

PTAL at my comment in md5sum.py

https://chromiumcodereview.appspot.com/1127133004/diff/20001/build/android/py...
File build/android/pylib/utils/md5sum.py (right):

https://chromiumcodereview.appspot.com/1127133004/diff/20001/build/android/py...
build/android/pylib/utils/md5sum.py:68: md5sum_script = (
do we need to modify md5sum executable to accept one fewer of arguments?

[jbudorick, 2015-05-11 18:40:20]

still lgtm

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/md5sum.py (right):

https://codereview.chromium.org/1127133004/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/md5sum.py:68: md5sum_script = (
On 2015/05/11 18:36:33, aurimas wrote:
> do we need to modify md5sum executable to accept one fewer of arguments?

No, the wrapper isn't an argument to md5sum. Removing {device_pie_wrapper} from
MD5SUM_DEVICE_SCRIPT_FORMAT is sufficient.

[aurimas (slooooooooow), 2015-05-11 18:41:26]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-05-11 18:41:27]

Thanks!

[commit-bot: I haz the power, 2015-05-11 18:44:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1127133004/40001

[commit-bot: I haz the power, 2015-05-11 19:50:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-11 19:51:08]

Patchset 3 (id:??) landed as
https://crrev.com/59c8117b4fa8d32377ff70fa25e2f15304e386f3
Cr-Commit-Position: refs/heads/master@{#329224}