build/android/pylib/gtest/test_package_exe.py - Issue 1127133004: Remove ICS support from build/android/pylib/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 1127133004: Remove ICS support from build/android/pylib/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index aa3374e29ce056ce839c364b1584b75cdf08bdc2..7cdcb99e5586b56c468c0fd7acd320da266b8e79 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -116,9 +116,8 @@ class TestPackageExecutable(TestPackage):

constants.TEST_EXECUTABLE_DIR, '%s_deps' % self.suite_name)

cmd = []

- for wrapper in (device.GetDevicePieWrapper(), self.tool.GetTestWrapper()):

- if wrapper:

- cmd.append(wrapper)

+ if self.tool.GetTestWrapper():

+ cmd.append(self.tool.GetTestWrapper())

cmd.extend([

posixpath.join(constants.TEST_EXECUTABLE_DIR, self.suite_name),

'--gtest_list_tests'])