Remove ICS support from build/android/pylib/

build/android/pylib/utils/md5sum.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import logging
 import os
 import re
 import tempfile
 import types
@@ skipping 47 matching lines @@
     md5sum_dist_path = os.path.join(constants.GetOutDirectory(), 'md5sum_dist')
     if not os.path.exists(md5sum_dist_path):
       raise IOError('File not built: %s' % md5sum_dist_path)
     device.adb.Push(md5sum_dist_path, MD5SUM_DEVICE_LIB_PATH)
 
   out = []
 
   with tempfile.NamedTemporaryFile() as md5sum_script_file:
     with device_temp_file.DeviceTempFile(
         device.adb) as md5sum_device_script_file:
-      device_pie_wrapper = device.GetDevicePieWrapper()
       md5sum_script = (

[aurimas (slooooooooow), 2015/05/11 18:36:33]

do we need to modify md5sum executable to accept one fewer of arguments?

[jbudorick, 2015/05/11 18:40:20]

No, the wrapper isn't an argument to md5sum. Removing {device_pie_wrapper} from
MD5SUM_DEVICE_SCRIPT_FORMAT is sufficient.

           MD5SUM_DEVICE_SCRIPT_FORMAT.format(
               path=p, md5sum_lib=MD5SUM_DEVICE_LIB_PATH,
-              device_pie_wrapper=device_pie_wrapper,
+              device_pie_wrapper='',

[aurimas (slooooooooow), 2015/05/11 17:45:23]

Can I remove this completely?

[jbudorick, 2015/05/11 17:49:41]

Yep.

               md5sum_bin=MD5SUM_DEVICE_BIN_PATH)
           for p in paths)
       md5sum_script_file.write('; '.join(md5sum_script))
       md5sum_script_file.flush()
       device.adb.Push(md5sum_script_file.name, md5sum_device_script_file.name)
       out = device.RunShellCommand(['sh', md5sum_device_script_file.name])
 
   return _ParseMd5SumOutput(out)
 
 
 def _ParseMd5SumOutput(out):
   hash_and_path = (l.split(None, 1) for l in out
                    if l and _STARTS_WITH_CHECKSUM_RE.match(l))
   return dict((p, h) for h, p in hash_and_path)