Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1127013005: Implement layoutAndPaintAsync() for WebPagePopupImpl and WebFrameWidgetImpl (Closed)

Created:
5 years, 7 months ago by Xianzhu
Modified:
5 years, 7 months ago
Reviewers:
chrishtr, enne (OOO)
CC:
blink-reviews, dcheng, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement layoutAndPaintAsync() for WebPagePopupImpl and WebFrameWidgetImpl Missing the implementations caused timeouts of layout tests requiring them. The timeout of css3/filters/huge-region.html should belong to crbug.com/458428 instead of crbug.com/484706. virtual/slimmingpaint/media/video-controls-dont-show-on-focus-when-disabled.html is crbug.com/485644. R=enne@chromium.org TBR=chrishtr@chromium.org BUG=484706, 458601, 485428, 485501, 485644 TEST=The failing tests of crbug.com/485428 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195070

Patch Set 1 #

Patch Set 2 : It also fixes crbug.com/485501 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -62 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +2 lines, -62 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebPagePopupImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Xianzhu
5 years, 7 months ago (2015-05-07 18:00:41 UTC) #2
enne (OOO)
lgtm
5 years, 7 months ago (2015-05-07 18:07:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127013005/20001
5 years, 7 months ago (2015-05-07 18:25:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127013005/20001
5 years, 7 months ago (2015-05-07 18:51:16 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 20:12:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195070

Powered by Google App Engine
This is Rietveld 408576698