Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/web/WebPagePopupImpl.h

Issue 1127013005: Implement layoutAndPaintAsync() for WebPagePopupImpl and WebFrameWidgetImpl (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: It also fixes crbug.com/485501 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebFrameWidgetImpl.cpp ('k') | Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 WTF_MAKE_FAST_ALLOCATED(WebPagePopupImpl); 58 WTF_MAKE_FAST_ALLOCATED(WebPagePopupImpl);
59 59
60 public: 60 public:
61 virtual ~WebPagePopupImpl(); 61 virtual ~WebPagePopupImpl();
62 bool initialize(WebViewImpl*, PagePopupClient*); 62 bool initialize(WebViewImpl*, PagePopupClient*);
63 bool handleKeyEvent(const PlatformKeyboardEvent&); 63 bool handleKeyEvent(const PlatformKeyboardEvent&);
64 void closePopup(); 64 void closePopup();
65 WebWidgetClient* widgetClient() const { return m_widgetClient; } 65 WebWidgetClient* widgetClient() const { return m_widgetClient; }
66 bool hasSamePopupClient(WebPagePopupImpl* other) { return other && m_popupCl ient == other->m_popupClient; } 66 bool hasSamePopupClient(WebPagePopupImpl* other) { return other && m_popupCl ient == other->m_popupClient; }
67 LocalDOMWindow* window(); 67 LocalDOMWindow* window();
68 virtual void layoutAndPaintAsync(WebLayoutAndPaintAsyncCallback*) override;
68 virtual void compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCallback* ) override; 69 virtual void compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCallback* ) override;
69 virtual WebPoint positionRelativeToOwner() override; 70 virtual WebPoint positionRelativeToOwner() override;
70 virtual void postMessage(const String& message) override; 71 virtual void postMessage(const String& message) override;
71 72
72 private: 73 private:
73 // WebWidget functions 74 // WebWidget functions
74 virtual WebSize size() override; 75 virtual WebSize size() override;
75 virtual void beginFrame(const WebBeginFrameArgs&) override; 76 virtual void beginFrame(const WebBeginFrameArgs&) override;
76 virtual void layout() override; 77 virtual void layout() override;
77 virtual void willCloseLayerTreeView() override; 78 virtual void willCloseLayerTreeView() override;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 friend class PagePopupChromeClient; 120 friend class PagePopupChromeClient;
120 }; 121 };
121 122
122 DEFINE_TYPE_CASTS(WebPagePopupImpl, WebWidget, widget, widget->isPagePopup(), wi dget.isPagePopup()); 123 DEFINE_TYPE_CASTS(WebPagePopupImpl, WebWidget, widget, widget->isPagePopup(), wi dget.isPagePopup());
123 // WebPagePopupImpl is the only implementation of PagePopup, so no 124 // WebPagePopupImpl is the only implementation of PagePopup, so no
124 // further checking required. 125 // further checking required.
125 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true); 126 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true);
126 127
127 } // namespace blink 128 } // namespace blink
128 #endif // WebPagePopupImpl_h 129 #endif // WebPagePopupImpl_h
OLDNEW
« no previous file with comments | « Source/web/WebFrameWidgetImpl.cpp ('k') | Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698