Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11267018: Make getKeys, getValues getters (keys, values). (Closed)

Created:
8 years, 2 months ago by floitsch
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make getKeys, getValues getters (keys, values). Committed: https://code.google.com/p/dart/source/detail?r=14093

Patch Set 1 #

Patch Set 2 : Update status files. #

Total comments: 3

Patch Set 3 : Update status files with co19 issue number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -297 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/CoreRuntimeTypesTest.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M lib/compiler/implementation/closure.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/compile_time_constants.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/compiler.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/dart_backend/backend.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/dart_backend/renamer.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/js_backend/backend.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/constant_map.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/library_loader.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/resolution/scope.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/variable_allocator.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/types/concrete_types_inferrer.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M lib/core/expect.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/core/map.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/coreimpl/hash_map_set.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/coreimpl/linked_hash_map.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/coreimpl/maps.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M lib/coreimpl/splay_tree.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 12 chunks +14 lines, -14 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 13 chunks +16 lines, -16 lines 0 comments Download
M lib/html/scripts/idlrenderer.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/html/src/Serialization.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/native_DOMImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/templates/html/impl/impl_Element.darttemplate View 1 9 chunks +9 lines, -9 lines 0 comments Download
M lib/html/templates/html/impl/impl_Storage.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/args/lib/args.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/dartdoc/lib/dartdoc.dart View 1 7 chunks +8 lines, -8 lines 0 comments Download
M pkg/dartdoc/lib/mirrors_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/markdown/html_renderer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/mirrors/util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/date_format.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/src/intl_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/src/lazy_locale_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/date_time_format_test_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/number_format_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/core_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/html_enhanced_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/mock.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/immutable_map.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M samples/markdown/html_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/Views.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/tests/samples/lib/layout/grid_layout_demo.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/layout/layout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/layout/GridTracks.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/observable/EventBatch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/util/CollectionUtils.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 5 chunks +6 lines, -6 lines 0 comments Download
M tests/corelib/core_runtime_types_test.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M tests/corelib/linked_hash_map_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/corelib/map_from_test.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M tests/corelib/map_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/corelib/maps_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/htmlelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/localstorage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/compile_time_constant_a_test.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M tests/language/compile_time_constant_b_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/ct_const_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/map_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/language/method_override_test.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M tests/language/ordered_maps_test.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/io/process_environment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/url_encoding_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/apidoc/html_diff.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/mdn/extract.dart View 1 6 chunks +6 lines, -6 lines 0 comments Download
M utils/apidoc/mdn/postProcess.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/apidoc/mdn/prettyPrint.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M utils/apidoc/mdn/util.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/archive/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/peg/pegparser.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/git_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/pubspec.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/version_solver.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M utils/pub/yaml/composer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/yaml/deep_equals.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/yaml/model.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/yaml/visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/yaml/yaml_map.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M utils/template/parser.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/testrunner/standard_test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/yaml_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
8 years, 1 month ago (2012-10-25 17:07:10 UTC) #1
Bob Nystrom
https://codereview.chromium.org/11267018/diff/2001/lib/core/map.dart File lib/core/map.dart (right): https://codereview.chromium.org/11267018/diff/2001/lib/core/map.dart#newcode72 lib/core/map.dart:72: Collection<K> get keys; It's like Christmas every morning when ...
8 years, 1 month ago (2012-10-25 17:11:36 UTC) #2
Mads Ager (google)
LGTM! https://codereview.chromium.org/11267018/diff/2001/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11267018/diff/2001/tests/co19/co19-dart2dart.status#newcode95 tests/co19/co19-dart2dart.status:95: # The following tests use getKeys/getValues instead of ...
8 years, 1 month ago (2012-10-25 19:07:16 UTC) #3
floitsch
8 years, 1 month ago (2012-10-25 19:16:51 UTC) #4 
https://codereview.chromium.org/11267018/diff/2001/tests/co19/co19-dart2dart....
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/11267018/diff/2001/tests/co19/co19-dart2dart....
tests/co19/co19-dart2dart.status:95: # The following tests use getKeys/getValues
instead of the keys/values getters.
On 2012/10/25 19:07:16, Mads Ager wrote:
> Remember the co19 bug when committing. :-)

Done.

Powered by Google App Engine
This is Rietveld 408576698