Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: pkg/dartdoc/lib/dartdoc.dart

Issue 11267018: Make getKeys, getValues getters (keys, values). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/args/lib/args.dart ('k') | pkg/dartdoc/lib/mirrors_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartdoc/lib/dartdoc.dart
diff --git a/pkg/dartdoc/lib/dartdoc.dart b/pkg/dartdoc/lib/dartdoc.dart
index e8aa075479b03805ca7cc5305a1e1f3c3870f5e6..13d5d0acf804aac1f8baef2a38db63a391a6465b 100644
--- a/pkg/dartdoc/lib/dartdoc.dart
+++ b/pkg/dartdoc/lib/dartdoc.dart
@@ -335,7 +335,7 @@ class Dartdoc {
void _document(Compilation compilation) {
// Sort the libraries by name (not key).
_sortedLibraries = new List<LibraryMirror>.from(
- compilation.mirrors.libraries.getValues().filter(
+ compilation.mirrors.libraries.values.filter(
shouldIncludeLibrary));
_sortedLibraries.sort((x, y) {
return displayName(x).toUpperCase().compareTo(
@@ -586,7 +586,7 @@ class Dartdoc {
}
final types = [];
- for (InterfaceMirror type in orderByName(library.types.getValues())) {
+ for (InterfaceMirror type in orderByName(library.types.values)) {
if (!showPrivate && type.isPrivate) continue;
var typeInfo = {};
@@ -622,7 +622,7 @@ class Dartdoc {
List docMembersJson(Map<Object,MemberMirror> memberMap) {
final members = [];
- for (MemberMirror member in orderByName(memberMap.getValues())) {
+ for (MemberMirror member in orderByName(memberMap.values)) {
if (!showPrivate && member.isPrivate) continue;
var memberInfo = {};
@@ -684,7 +684,7 @@ class Dartdoc {
final types = <InterfaceMirror>[];
final exceptions = <InterfaceMirror>[];
- for (InterfaceMirror type in orderByName(library.types.getValues())) {
+ for (InterfaceMirror type in orderByName(library.types.values)) {
if (!showPrivate && type.isPrivate) continue;
if (isException(type)) {
@@ -750,7 +750,7 @@ class Dartdoc {
final typedefs = <TypedefMirror>[];
final exceptions = <InterfaceMirror>[];
- for (InterfaceMirror type in orderByName(library.types.getValues())) {
+ for (InterfaceMirror type in orderByName(library.types.values)) {
if (!showPrivate && type.isPrivate) continue;
if (isException(type)) {
@@ -774,7 +774,7 @@ class Dartdoc {
writeFooter();
endFile();
- for (final type in library.types.getValues()) {
+ for (final type in library.types.values) {
if (!showPrivate && type.isPrivate) continue;
docType(type);
@@ -1141,8 +1141,8 @@ class Dartdoc {
{bool allInherited}) {
if (getters.isEmpty && setters.isEmpty) return;
- var nameSet = new Set<String>.from(getters.getKeys());
- nameSet.addAll(setters.getKeys());
+ var nameSet = new Set<String>.from(getters.keys);
+ nameSet.addAll(setters.keys);
var nameList = new List<String>.from(nameSet);
nameList.sort((String a, String b) {
return a.toLowerCase().compareTo(b.toLowerCase());
« no previous file with comments | « pkg/args/lib/args.dart ('k') | pkg/dartdoc/lib/mirrors_util.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698