Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: utils/apidoc/mdn/extract.dart

Issue 11267018: Make getKeys, getValues getters (keys, values). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status files with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/apidoc/html_diff.dart ('k') | utils/apidoc/mdn/postProcess.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/apidoc/mdn/extract.dart
diff --git a/utils/apidoc/mdn/extract.dart b/utils/apidoc/mdn/extract.dart
index 062d3c2c6e4d545bd5be0eb1abe44e95d7a5ecdf..c8d54d2672fdf1a93157a063fc515da399dfea90 100644
--- a/utils/apidoc/mdn/extract.dart
+++ b/utils/apidoc/mdn/extract.dart
@@ -834,7 +834,7 @@ void scrapeSection(Element root, String sectionSelector, String currentType,
final allText = getAllTextNodes(match);
final pmap = new Map<String, Element>();
- for (final prop in expectedProps.getKeys()) {
+ for (final prop in expectedProps.keys) {
if (alreadyMatchedProperties.contains(prop)) {
continue;
}
@@ -844,7 +844,7 @@ void scrapeSection(Element root, String sectionSelector, String currentType,
}
}
- for (final prop in pmap.getKeys()) {
+ for (final prop in pmap.keys) {
pmap[prop].classes.add(DART_REMOVED);
}
@@ -875,7 +875,7 @@ void scrapeSection(Element root, String sectionSelector, String currentType,
// carefully check that the documentation for each method comment is
// visually consistent but take less care to check that each
// method comment has identical markup structure.
- for (String prop in pmap.getKeys()) {
+ for (String prop in pmap.keys) {
Element e = pmap[prop];
ClientRect r = getClientRect(e);
// TODO(jacobr): a lot of these queries are identical and this code
@@ -901,7 +901,7 @@ void scrapeSection(Element root, String sectionSelector, String currentType,
// We mark these elements in batch to reduce the number of layouts
// triggered. TODO(jacobr): use new batch based async measurement to make
// this code flow simpler.
- for (String prop in pmap.getKeys()) {
+ for (String prop in pmap.keys) {
Element e = pmap[prop];
e.classes.add(DART_REMOVED);
}
@@ -915,7 +915,7 @@ void scrapeSection(Element root, String sectionSelector, String currentType,
}
}
- for (String prop in pmap.getKeys()) {
+ for (String prop in pmap.keys) {
Element elem = pmap[prop];
bool obsolete = false;
final parse = filteredHtml(
@@ -1031,7 +1031,7 @@ void cleanupEntry(List members, Map entry) {
String name = fullNameCleanup(entry['name']);
entry['name'] = name;
if (maybeName(name)) {
- for (String key in entry.getKeys()) {
+ for (String key in entry.keys) {
var value = entry[key];
if (value == null) {
entry.remove(key);
« no previous file with comments | « utils/apidoc/html_diff.dart ('k') | utils/apidoc/mdn/postProcess.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698