Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1126613003: Revert of Move instanced index buffer creation to flush time (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move instanced index buffer creation to flush time (patchset #6 id:100001 of https://codereview.chromium.org/1116943004/) Reason for revert: messed up caching, recreating index buffers all the time. Original issue's description: > Move instanced index buffer creation to flush time > > Committed: https://skia.googlesource.com/skia/+/ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26 TBR=joshualitt@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d8ed1b64a6c85a8364c23e825164b7bebb43a3a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -513 lines) Patch
M gm/beziereffects.cpp View 6 chunks +7 lines, -11 lines 0 comments Download
M gm/convexpolyeffect.cpp View 4 chunks +3 lines, -6 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkOnce.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrResourceKey.h View 2 chunks +0 lines, -19 lines 0 comments Download
M include/gpu/GrTextureProvider.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 4 chunks +10 lines, -14 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.h View 1 chunk +22 lines, -15 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 28 chunks +117 lines, -72 lines 0 comments Download
M src/gpu/GrAARectRenderer.h View 3 chunks +19 lines, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 22 chunks +200 lines, -154 lines 0 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M src/gpu/GrBatchTarget.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +12 lines, -2 lines 0 comments Download
M src/gpu/GrDashLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +30 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.cpp View 3 chunks +60 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrOvalRenderer.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 34 chunks +92 lines, -59 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +1 line, -59 lines 0 comments Download
D src/gpu/GrResourceProvider.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Move instanced index buffer creation to flush time
5 years, 7 months ago (2015-05-04 17:08:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126613003/1
5 years, 7 months ago (2015-05-04 17:09:03 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 17:09:30 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d8ed1b64a6c85a8364c23e825164b7bebb43a3a0

Powered by Google App Engine
This is Rietveld 408576698