Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1126463005: Clean up WheelEvent (Closed)

Created:
5 years, 7 months ago by Alan Knight
Modified:
5 years, 7 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Small cleanups #

Total comments: 6

Patch Set 3 : Review fixes" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -364 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 6 chunks +40 lines, -116 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 4 chunks +11 lines, -16 lines 0 comments Download
M tests/html/event_test.dart View 1 8 chunks +27 lines, -55 lines 0 comments Download
M tests/html/html.status View 4 chunks +1 line, -5 lines 0 comments Download
A + tests/html/text_event_test.dart View 1 chunk +7 lines, -9 lines 0 comments Download
M tests/html/wheelevent_test.dart View 1 2 3 chunks +23 lines, -12 lines 0 comments Download
M tools/dom/dom.json View 1 chunk +3 lines, -18 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_ElementEvents.darttemplate View 1 chunk +1 line, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CompositionEvent.darttemplate View 1 2 1 chunk +15 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 4 chunks +14 lines, -103 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
Also make the other event tests pass, which required fixing some other minor problems.
5 years, 7 months ago (2015-05-05 00:38:11 UTC) #2
terry
Alan, lgtm just a few questions. https://codereview.chromium.org/1126463005/diff/20001/tests/html/event_test.dart File tests/html/event_test.dart (right): https://codereview.chromium.org/1126463005/diff/20001/tests/html/event_test.dart#newcode187 tests/html/event_test.dart:187: expect(ev.deltaY, 0); Should ...
5 years, 7 months ago (2015-05-11 21:34:25 UTC) #3
Alan Knight
https://codereview.chromium.org/1126463005/diff/20001/tests/html/event_test.dart File tests/html/event_test.dart (right): https://codereview.chromium.org/1126463005/diff/20001/tests/html/event_test.dart#newcode187 tests/html/event_test.dart:187: expect(ev.deltaY, 0); On 2015/05/11 21:34:25, terry wrote: > Should ...
5 years, 7 months ago (2015-05-12 00:25:26 UTC) #4
Alan Knight
5 years, 7 months ago (2015-05-12 16:34:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698