Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 1126463005: Clean up WheelEvent (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review fixes" Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/event_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 93033247a4a143bc26559f6504defac36e4d6354..4adb04e628a78ef9d0808e6b7b6d70c10de43291 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -3476,14 +3476,17 @@ class Comment extends CharacterData {
class CompositionEvent extends UIEvent {
factory CompositionEvent(String type,
{bool canBubble: false, bool cancelable: false, Window view,
- String data}) {
+ String data, String locale}) {
if (view == null) {
view = window;
}
var e = document._createEvent("CompositionEvent");
- e._initCompositionEvent(type, canBubble, cancelable, view, data);
+
+ e._initCompositionEvent(type, canBubble, cancelable, view, data);
+
return e;
}
+
// To suppress missing implicit constructor warnings.
factory CompositionEvent._() { throw new UnsupportedError("Not supported"); }
@@ -32952,15 +32955,19 @@ class WebSocket extends EventTarget {
class WheelEvent extends MouseEvent {
factory WheelEvent(String type,
- {Window view, int deltaX: 0, int deltaY: 0,
+ {Window view, int deltaX: 0, int deltaY: 0, int deltaZ: 0,
+ int deltaMode: 0,
int detail: 0, int screenX: 0, int screenY: 0, int clientX: 0,
int clientY: 0, int button: 0, bool canBubble: true,
bool cancelable: true, bool ctrlKey: false, bool altKey: false,
bool shiftKey: false, bool metaKey: false, EventTarget relatedTarget}) {
+
var options = {
'view': view,
+ 'deltaMode': deltaMode,
'deltaX': deltaX,
'deltaY': deltaY,
+ 'deltaZ': deltaZ,
'detail': detail,
'screenX': screenX,
'screenY': screenY,
@@ -32975,6 +32982,7 @@ class WheelEvent extends MouseEvent {
'metaKey': metaKey,
'relatedTarget': relatedTarget,
};
+
return _blink.BlinkWheelEvent.constructorCallback_2(type, options);
}
@@ -32999,29 +33007,16 @@ class WheelEvent extends MouseEvent {
@DomName('WheelEvent.deltaX')
@DocsEditable()
- @Experimental() // untriaged
double get _deltaX => _blink.BlinkWheelEvent.instance.deltaX_Getter_(this);
@DomName('WheelEvent.deltaY')
@DocsEditable()
- @Experimental() // untriaged
double get _deltaY => _blink.BlinkWheelEvent.instance.deltaY_Getter_(this);
@DomName('WheelEvent.deltaZ')
@DocsEditable()
- @Experimental() // untriaged
double get deltaZ => _blink.BlinkWheelEvent.instance.deltaZ_Getter_(this);
- @DomName('WheelEvent.wheelDeltaX')
- @DocsEditable()
- @Experimental() // non-standard
- int get wheelDeltaX => _blink.BlinkWheelEvent.instance.wheelDeltaX_Getter_(this);
-
- @DomName('WheelEvent.wheelDeltaY')
- @DocsEditable()
- @Experimental() // non-standard
- int get wheelDeltaY => _blink.BlinkWheelEvent.instance.wheelDeltaY_Getter_(this);
-
/**
* The amount that is expected to scroll horizontally, in units determined by
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tests/html/event_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698