Issue 1126253008: Use StrongBinding in NativeViewportImpl instead of manually deleting-on-connection-error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1126253008: Use StrongBinding in NativeViewportImpl instead of manually deleting-on-connection-error. (Closed)

Created:
5 years, 7 months ago by jam

Modified:
5 years, 6 months ago

Reviewers:
yzshen1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Use StrongBinding in NativeViewportImpl instead of manually deleting-on-connection-error. Committed: https://crrev.com/9b1a0b64b99ed2cc94941d4c905ef56b1f67ce8a Cr-Commit-Position: refs/heads/master@{#332004}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -12 lines)			Patch
	M	components/view_manager/native_viewport/native_viewport_impl.h	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
	M	components/view_manager/native_viewport/native_viewport_impl.cc	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126253008/20001

5 years, 6 months ago (2015-05-29 17:43:45 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 17:53:16 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/9b1a0b64b99ed2cc94941d4c905ef56b1f67ce8a
Cr-Commit-Position: refs/heads/master@{#332004}