Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: components/view_manager/native_viewport/native_viewport_impl.h

Issue 1126253008: Use StrongBinding in NativeViewportImpl instead of manually deleting-on-connection-error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/view_manager/native_viewport/native_viewport_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/view_manager/native_viewport/native_viewport_impl.h
diff --git a/components/view_manager/native_viewport/native_viewport_impl.h b/components/view_manager/native_viewport/native_viewport_impl.h
index f298a536637119a62a4b4fca1914d14a7bcbab05..2c21b1411d1b0723dd536636af567b2e76fd5cfe 100644
--- a/components/view_manager/native_viewport/native_viewport_impl.h
+++ b/components/view_manager/native_viewport/native_viewport_impl.h
@@ -32,8 +32,7 @@ namespace native_viewport {
// or the PlatformViewport informs the NativeViewportImpl that it has been
// destroyed.
class NativeViewportImpl : public mojo::NativeViewport,
- public PlatformViewport::Delegate,
- public mojo::ErrorHandler {
+ public PlatformViewport::Delegate {
public:
NativeViewportImpl(bool is_headless,
const scoped_refptr<gles2::GpuState>& gpu_state,
@@ -61,9 +60,6 @@ class NativeViewportImpl : public mojo::NativeViewport,
bool OnEvent(mojo::EventPtr event) override;
void OnDestroyed() override;
- // mojo::ErrorHandler implementation.
- void OnConnectionError() override;
-
private:
// Callback when the dispatcher has processed a message we're waiting on
// an ack from. |pointer_id| identifies the pointer the message was associated
@@ -79,7 +75,7 @@ class NativeViewportImpl : public mojo::NativeViewport,
CreateCallback create_callback_;
RequestMetricsCallback metrics_callback_;
mojo::NativeViewportEventDispatcherPtr event_dispatcher_;
- mojo::Binding<mojo::NativeViewport> binding_;
+ mojo::StrongBinding<mojo::NativeViewport> binding_;
// Set of pointer_ids we've sent a move to and are waiting on an ack.
std::set<int32> pointers_waiting_on_ack_;
« no previous file with comments | « no previous file | components/view_manager/native_viewport/native_viewport_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698