Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: components/view_manager/native_viewport/native_viewport_impl.cc

Issue 1126253008: Use StrongBinding in NativeViewportImpl instead of manually deleting-on-connection-error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/view_manager/native_viewport/native_viewport_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/view_manager/native_viewport/native_viewport_impl.cc
diff --git a/components/view_manager/native_viewport/native_viewport_impl.cc b/components/view_manager/native_viewport/native_viewport_impl.cc
index 5c623940206a114d0a7acdcfea38cbc53366dc41..e990cbdcc71414a76140ca028d4db58091af4ca7 100644
--- a/components/view_manager/native_viewport/native_viewport_impl.cc
+++ b/components/view_manager/native_viewport/native_viewport_impl.cc
@@ -29,7 +29,6 @@ NativeViewportImpl::NativeViewportImpl(
metrics_(mojo::ViewportMetrics::New()),
binding_(this, request.Pass()),
weak_factory_(this) {
- binding_.set_error_handler(this);
}
NativeViewportImpl::~NativeViewportImpl() {
@@ -160,11 +159,6 @@ void NativeViewportImpl::OnDestroyed() {
delete this;
}
-void NativeViewportImpl::OnConnectionError() {
- binding_.set_error_handler(nullptr);
- delete this;
-}
-
void NativeViewportImpl::AckEvent(int32 pointer_id) {
pointers_waiting_on_ack_.erase(pointer_id);
}
« no previous file with comments | « components/view_manager/native_viewport/native_viewport_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698