Check for inputs not generated by deps

Check for inputs not generated by deps

Adds a check in GN that looks for generated input files on a target that were
not generated by a dependency of the current target. In order to depend on the
output of a previous target, that target must be in your deps.

This adds checking output files to "gn refs" to help in debugging these issues.

Relaxes a wider range of checking when doing introspection commands like
"desc", "refs", and "ls" so they can be run to debug such issues.

Adds an additional test helper for setting up test targets that saves some code. Use this in the target unittests.

Committed: https://crrev.com/56affab3b067e55d692281864d98a78a96aa21cc
Cr-Commit-Position: refs/heads/master@{#332925}

[brettw, 2015-05-14 20:13:10]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-14 20:13:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126193005/1

[commit-bot: I haz the power, 2015-05-14 20:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 20:30:27]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-05-14 22:40:26]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-05-14 22:51:45]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-14 22:55:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126193005/40001

[scottmg, 2015-05-14 23:04:05]

lgtm

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target.cc
File tools/gn/target.cc (right):

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target.cc#newc...
tools/gn/target.cc:80: for (const OutputFile& cur : target->computed_outputs())
{
(this could be std::find, but whatever you prefer)

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target_unittes...
File tools/gn/target_unittest.cc (right):

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target_unittes...
tools/gn/target_unittest.cc:302: TestTarget g(setup, "//private:g",
Target::GROUP);
"private" -> "public"?

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target_unittes...
tools/gn/target_unittest.cc:444: TestTarget exe(setup, "//foo:exe",
Target::EXECUTABLE);
confirm you meant to change this to EXECUTABLE

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target_unittes...
tools/gn/target_unittest.cc:464: TestTarget non_existant_generator(setup,
"//foo:non_existant_generator",
"existant" -> "existent" in few places

[brettw, 2015-05-14 23:21:03]

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target.cc
File tools/gn/target.cc (right):

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target.cc#newc...
tools/gn/target.cc:80: for (const OutputFile& cur : target->computed_outputs())
{
In this case the find code is silly looking because of hte long name of the
container.

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target_unittes...
File tools/gn/target_unittest.cc (right):

https://codereview.chromium.org/1126193005/diff/40001/tools/gn/target_unittes...
tools/gn/target_unittest.cc:444: TestTarget exe(setup, "//foo:exe",
Target::EXECUTABLE);
Nice catch, although this type is basically random.

[brettw, 2015-05-14 23:21:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-05-14 23:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1126193005/#ps60001
(title: "review comments")

[commit-bot: I haz the power, 2015-05-14 23:24:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126193005/60001

[commit-bot: I haz the power, 2015-05-14 23:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 23:41:39]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-05-18 18:26:07]

Scott: you may want to take another look, this moved around a bunch. The Target
code is mostly the same, but instead of throwing an error, it will just notify
the global scheduler. write_file also notifies the global scheduler of files
written so these files can be filtered out of the list of unknown dependencies.

The code that actually does the errors moved to command_gen at the end of the
run. This ends up being much more user-friendly because targets depending on a
single file can be grouped, and we can list exactly which target generates the
file.

[brettw, 2015-05-18 18:26:13]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-05-18 18:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1126193005/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-05-18 18:26:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126193005/120001

[commit-bot: I haz the power, 2015-05-18 20:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-18 20:05:12]

Dry run: This issue passed the CQ dry run.

[scottmg, 2015-05-19 17:10:41]

lgtm

https://codereview.chromium.org/1126193005/diff/160001/tools/gn/target_unitte...
File tools/gn/target_unittest.cc (right):

https://codereview.chromium.org/1126193005/diff/160001/tools/gn/target_unitte...
tools/gn/target_unittest.cc:549:
scheduler.ClearUnknownGeneratedInputsAndWrittenFiles();
seems like making a new scheduler rather than this tidying function would be a
bit cleaner.

https://codereview.chromium.org/1126193005/diff/160001/tools/gn/target_unitte...
tools/gn/target_unittest.cc:551: // This target has a generated file and we've
decared we write it.
"declared"

[brettw, 2015-06-04 20:29:08]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-06-04 20:29:08]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1126193005/#ps200001
(title: " ")

[commit-bot: I haz the power, 2015-06-04 20:29:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126193005/200001

[commit-bot: I haz the power, 2015-06-04 21:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 21:00:43]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-06-04 21:51:32]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-06-04 21:53:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126193005/200001

[commit-bot: I haz the power, 2015-06-04 22:01:18]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-06-04 22:02:16]

Patchset 11 (id:??) landed as
https://crrev.com/56affab3b067e55d692281864d98a78a96aa21cc
Cr-Commit-Position: refs/heads/master@{#332925}