Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: tools/gn/setup.h

Issue 1126193005: Check for inputs not generated by deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/scheduler.cc ('k') | tools/gn/setup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/setup.h
diff --git a/tools/gn/setup.h b/tools/gn/setup.h
index 2e028e339d87ce3be9a8980e4296ea947a8ee3c0..9c8736797f0c6699048b177d675014b4cced9306 100644
--- a/tools/gn/setup.h
+++ b/tools/gn/setup.h
@@ -68,16 +68,6 @@ class Setup {
// want to rely on them being valid.
void set_fill_arguments(bool fa) { fill_arguments_ = fa; }
- // When true (the default), Run() will check for unresolved dependencies and
- // cycles upon completion. When false, such errors will be ignored.
- void set_check_for_bad_items(bool s) { check_for_bad_items_ = s; }
-
- // When true (the default), RunPostMessageLoop will check for overrides that
- // were specified but not used. When false, such errors will be ignored.
- void set_check_for_unused_overrides(bool s) {
- check_for_unused_overrides_ = s;
- }
-
// After a successful run, setting this will additionally cause the public
// headers to be checked. Defaults to false.
void set_check_public_headers(bool s) {
@@ -142,8 +132,6 @@ class Setup {
SourceFile root_build_file_;
- bool check_for_bad_items_;
- bool check_for_unused_overrides_;
bool check_public_headers_;
// See getter for info.
« no previous file with comments | « tools/gn/scheduler.cc ('k') | tools/gn/setup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698