Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/gn/setup.cc

Issue 1126193005: Check for inputs not generated by deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@data
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/setup.h ('k') | tools/gn/target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/setup.cc
diff --git a/tools/gn/setup.cc b/tools/gn/setup.cc
index 79c46e79ce18afd4bdd6a6314f1b176aecaf512c..aa8e8f0b3d2d1e0026d43ca5901f8ff1244a36d5 100644
--- a/tools/gn/setup.cc
+++ b/tools/gn/setup.cc
@@ -157,8 +157,6 @@ Setup::Setup()
loader_(new LoaderImpl(&build_settings_)),
builder_(new Builder(loader_.get())),
root_build_file_("//BUILD.gn"),
- check_for_bad_items_(true),
- check_for_unused_overrides_(true),
check_public_headers_(false),
dotfile_settings_(&build_settings_, std::string()),
dotfile_scope_(&dotfile_settings_),
@@ -234,14 +232,12 @@ void Setup::RunPreMessageLoop() {
bool Setup::RunPostMessageLoop() {
Err err;
- if (check_for_bad_items_) {
+ if (build_settings_.check_for_bad_items()) {
if (!builder_->CheckForBadItems(&err)) {
err.PrintToStdout();
return false;
}
- }
- if (check_for_unused_overrides_) {
if (!build_settings_.build_args().VerifyAllOverridesUsed(&err)) {
// TODO(brettw) implement a system of warnings. Until we have a better
// system, print the error but don't return failure.
« no previous file with comments | « tools/gn/setup.h ('k') | tools/gn/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698