Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1126133003: CSS: Drop the quirks-mode exception for CSS MIME types. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, tyoshino+watch_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSS: Drop the quirks-mode exception for CSS MIME types. This matches Firefox's behavior (though it returns 'transparent' instead of 'rgba(0, 0, 0, 0)', which is a bit annoying). --------------------------------------------------------------------------- This is a reland of https://codereview.chromium.org/733993002, which was reverted after breaking tests. https://codereview.chromium.org/1136493003 fixes those tests by sending a correct MIME type for CSS files. The patch is otherwise identical % rebasing. --------------------------------------------------------------------------- BUG=419383 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195266

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -62 lines) Patch
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/misc/css-accept-any-type.html View 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/misc/css-accept-any-type-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-origin-css.html View 1 3 chunks +50 lines, -29 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-css-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Mike West
https://codereview.chromium.org/1136493003 should fix the Chromium-side breakage this patch introduced the first time it landed. Jochen, ...
5 years, 7 months ago (2015-05-11 13:40:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-11 23:34:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126133003/20001
5 years, 7 months ago (2015-05-12 05:56:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 05:59:59 UTC) #7
Mike West
On 2015/05/12 at 05:59:59, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
5 years, 7 months ago (2015-05-12 08:58:02 UTC) #8
Mike West
On 2015/05/12 at 08:58:02, Mike West wrote: > On 2015/05/12 at 05:59:59, commit-bot wrote: > ...
5 years, 7 months ago (2015-05-12 09:27:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126133003/20001
5 years, 7 months ago (2015-05-12 13:20:27 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 18:29:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195266

Powered by Google App Engine
This is Rietveld 408576698