Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 733993002: CSS: Drop the quirks-mode exception for CSS MIME types. (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
5 years, 10 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, caseq+blink_chromium.org, Charlie Reis, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, gavinp+loader_chromium.org, Nate Chapin, lcamtuf1, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, Tab Atkins, tyoshino+watch_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSS: Drop the quirks-mode exception for CSS MIME types. This matches Firefox's behavior (though it returns 'transparent' instead of 'rgba(0, 0, 0, 0)', which is a bit annoying). BUG=419383 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189669

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : testharness. #

Patch Set 4 : Tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -58 lines) Patch
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/misc/css-accept-any-type.html View 1 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/misc/css-accept-any-type-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-origin-css.html View 1 2 3 chunks +56 lines, -26 lines 0 comments Download
D LayoutTests/http/tests/security/cross-origin-css-expected.txt View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 3 chunks +3 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Mike West
This matches Firefox's behavior (though it returns 'transparent' instead of 'rgba(0, 0, 0, 0)' :( ...
5 years, 10 months ago (2015-02-06 12:34:41 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-06 12:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733993002/60001
5 years, 10 months ago (2015-02-06 13:40:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733993002/60001
5 years, 10 months ago (2015-02-06 19:32:35 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=189669
5 years, 10 months ago (2015-02-06 19:33:37 UTC) #9
Dirk Pranke
On 2015/02/06 19:33:37, I haz the power (commit-bot) wrote: > Committed patchset #4 (id:60001) as ...
5 years, 10 months ago (2015-02-06 23:32:11 UTC) #10
Dirk Pranke
5 years, 10 months ago (2015-02-07 01:38:20 UTC) #11
Message was sent while issue was closed.
Follow-up: it looks like this patch was causing the test failures; the bots have
greened up and the next blink roll (the first with the revert) did go through.

Powered by Google App Engine
This is Rietveld 408576698