Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1136493003: Send proper MIME type along with PPAPI test CSS files. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send proper MIME type along with PPAPI test CSS files. https://codereview.chromium.org/1126133003 changes the behavior of Blink CSS file support; we need to send the proper MIME type, even in quirks mode. This CL fixes the tests which broke when that patch initially landed way back when. BUG=419383 TBR=bbudge@chromium.org Committed: https://crrev.com/b28d5ba5a59654d9d32e2420c4173483c1a21ac4 Cr-Commit-Position: refs/heads/master@{#329358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ppapi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + ppapi/tests/test_page.css.mock-http-headers View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Mike West
Hi! Would you mind taking a look at this tiny patch? It just adds headers ...
5 years, 7 months ago (2015-05-11 13:40:12 UTC) #2
Mike West
Jochen, perhaps you could skim this patch as an almost-top-level OWNER? There's no real PPAPI ...
5 years, 7 months ago (2015-05-12 04:23:27 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-12 04:35:10 UTC) #5
Mike West
On 2015/05/12 at 04:35:10, jochen wrote: > lgtm Thanks. TBRing bbudge@ for ppapi/.
5 years, 7 months ago (2015-05-12 05:42:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136493003/1
5 years, 7 months ago (2015-05-12 05:43:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 05:48:00 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 05:48:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b28d5ba5a59654d9d32e2420c4173483c1a21ac4
Cr-Commit-Position: refs/heads/master@{#329358}

Powered by Google App Engine
This is Rietveld 408576698