Issue 1125193006: Revert of add option to supress prints on context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125193006: Revert of add option to supress prints on context (Closed)

Created:
5 years, 7 months ago by joshualitt

Modified:
5 years, 7 months ago

Reviewers:
bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of add option to supress prints on context (patchset #5 id:80001 of https://codereview.chromium.org/1128903008/) Reason for revert: breaks windows rollbots Original issue's description: > add option to supress prints on context > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/55661337667a8305ebb100e36af23d34c2fb83ba TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee71044d4b7aa1703cd9c04d5322f5d2df1e7c25

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -28 lines)			Patch
M	include/gpu/GrContext.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	include/gpu/GrTypesPriv.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDataManager.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgramDataManager.cpp	View	12 chunks	+12 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of add option to supress prints on context

5 years, 7 months ago (2015-05-12 15:33:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193006/1

5 years, 7 months ago (2015-05-12 15:33:23 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 15:33:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee71044d4b7aa1703cd9c04d5322f5d2df1e7c25