Issue 1124813005: WIP Atomics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1124813005: WIP Atomics (Closed)

Created:
5 years, 7 months ago by binji

Modified:
5 years, 6 months ago

Reviewers:

CC:
v8-dev, Jarin, Benedikt Meurer

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

WIP Atomics BUG=

Patch Set 1 #

Patch Set 2 : TF implementation of Atomics.load #

Patch Set 3 : . #

Patch Set 4 : fix AtomicsLoad type in typer.cc #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1565 lines, -11 lines)			Patch
M	BUILD.gn	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	1	9 chunks	+36 lines, -5 lines	0 comments	Download
M	src/compiler/instruction-selector.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler/js-builtin-reducer.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/js-builtin-reducer.cc	View	1 2	3 chunks	+82 lines, -0 lines	0 comments	Download
M	src/compiler/machine-operator.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/machine-operator.cc	View	1	2 chunks	+26 lines, -1 line	0 comments	Download
M	src/compiler/opcodes.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/compiler/simplified-operator.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/simplified-operator.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/compiler/typer.cc	View	1 2 3	5 chunks	+17 lines, -0 lines	0 comments	Download
M	src/compiler/verifier.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	src/harmony-atomics.js	View	1	1 chunk	+170 lines, -0 lines	0 comments	Download
M	src/messages.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/runtime/runtime.h	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download
A	src/runtime/runtime-atomics.cc	View	1	1 chunk	+555 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-typedarray.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-utils.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/mjsunit/asm/atomics-load.js	View	1 2 3	1 chunk	+68 lines, -0 lines	0 comments	Download
A	test/mjsunit/harmony/atomics.js	View	1 2 3	1 chunk	+476 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

binji

5 years, 7 months ago (2015-05-20 14:37:40 UTC) #1

PTAL. Initial pass at Atomics w/ Atomics.load implemented in turbofan

Expand Messages | Collapse Messages