Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124493002: Cleanup: given that TLS slot can't fail to initialize, remove bool return values (Closed)

Created:
5 years, 7 months ago by vadimt
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@parchild
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: given that TLS slot can't fail to initialize, remove bool return values from initialization functions that actually can't fail. BUG=456354

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -145 lines) Patch
M base/profiler/tracked_time_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M base/threading/thread_local_storage.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/threading/thread_local_storage.cc View 2 chunks +1 line, -2 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M base/tracked_objects.h View 1 chunk +3 lines, -4 lines 0 comments Download
M base/tracked_objects.cc View 6 chunks +9 lines, -14 lines 1 comment Download
M base/tracked_objects_unittest.cc View 24 chunks +24 lines, -111 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
5 years, 7 months ago (2015-05-01 22:58:15 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-04 15:37:36 UTC) #3
vadimt
cpu@chromium.org: Please provide OWNER's approval.
5 years, 7 months ago (2015-05-04 18:08:56 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/1124493002/diff/1/base/tracked_objects.cc File base/tracked_objects.cc (right): https://codereview.chromium.org/1124493002/diff/1/base/tracked_objects.cc#newcode391 base/tracked_objects.cc:391: Initialize(); // Always initialize if needed. remove 0 ...
5 years, 7 months ago (2015-05-05 20:49:35 UTC) #6
Alexei Svitkine (slow)
Vadim off of Chrome and apparently already re-imaged his machine, so I'll take this over ...
5 years, 7 months ago (2015-05-05 21:23:42 UTC) #7
Alexei Svitkine (slow)
5 years, 7 months ago (2015-05-05 21:29:18 UTC) #8 
On 2015/05/05 21:23:42, Alexei Svitkine wrote:
> Vadim off of Chrome and apparently already re-imaged his machine, so I'll take
> this over and address the comment.

Sent updated CL with cpu@'s comment addressed here:
https://codereview.chromium.org/1128653002/

Powered by Google App Engine
This is Rietveld 408576698