Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: base/tracked_objects.h

Issue 1124493002: Cleanup: given that TLS slot can't fail to initialize, remove bool return values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@parchild
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/tracked_objects.h
diff --git a/base/tracked_objects.h b/base/tracked_objects.h
index cd69fb7e008115028e4ae9583e828bf9524557ff..e751ba67c94e6ce466923db7df97f440ee0dd169 100644
--- a/base/tracked_objects.h
+++ b/base/tracked_objects.h
@@ -497,14 +497,13 @@ class BASE_EXPORT ThreadData {
const std::string& thread_name() const { return thread_name_; }
// Initializes all statics if needed (this initialization call should be made
- // while we are single threaded). Returns false if unable to initialize.
- static bool Initialize();
+ // while we are single threaded).
+ static void Initialize();
// Sets internal status_.
// If |status| is false, then status_ is set to DEACTIVATED.
// If |status| is true, then status_ is set to PROFILING_ACTIVE.
- // If it fails to initialize the TLS slot, this function will return false.
- static bool InitializeAndSetTrackingStatus(Status status);
+ static void InitializeAndSetTrackingStatus(Status status);
static Status status();

Powered by Google App Engine
This is Rietveld 408576698