Cleanup: given that TLS slot can't fail to initialize, remove bool return values

base/threading/thread_local_storage.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/thread_local_storage.h"
 
 #include "base/atomicops.h"
 #include "base/logging.h"
 
 using base::internal::PlatformThreadLocalStorage;
@@ skipping 179 matching lines @@
 #endif  // defined(OS_WIN)
 
 }  // namespace internal
 
 ThreadLocalStorage::Slot::Slot(TLSDestructorFunc destructor) {
   initialized_ = false;
   slot_ = 0;
   Initialize(destructor);
 }
 
-bool ThreadLocalStorage::StaticSlot::Initialize(TLSDestructorFunc destructor) {
+void ThreadLocalStorage::StaticSlot::Initialize(TLSDestructorFunc destructor) {
   PlatformThreadLocalStorage::TLSKey key =
       base::subtle::NoBarrier_Load(&g_native_tls_key);
   if (key == PlatformThreadLocalStorage::TLS_KEY_OUT_OF_INDEXES ||
       !PlatformThreadLocalStorage::GetTLSValue(key))
     ConstructTlsVector();
 
   // Grab a new slot.
   slot_ = base::subtle::NoBarrier_AtomicIncrement(&g_last_used_tls_key, 1);
   DCHECK_GT(slot_, 0);
   CHECK_LT(slot_, kThreadLocalStorageSize);
 
   // Setup our destructor.
   g_tls_destructors[slot_] = destructor;
   initialized_ = true;
-  return true;
 }
 
 void ThreadLocalStorage::StaticSlot::Free() {
   // At this time, we don't reclaim old indices for TLS slots.
   // So all we need to do is wipe the destructor.
   DCHECK_GT(slot_, 0);
   DCHECK_LT(slot_, kThreadLocalStorageSize);
   g_tls_destructors[slot_] = NULL;
   slot_ = 0;
   initialized_ = false;
@@ skipping 15 matching lines @@
       PlatformThreadLocalStorage::GetTLSValue(
           base::subtle::NoBarrier_Load(&g_native_tls_key)));
   if (!tls_data)
     tls_data = ConstructTlsVector();
   DCHECK_GT(slot_, 0);
   DCHECK_LT(slot_, kThreadLocalStorageSize);
   tls_data[slot_] = value;
 }
 
 }  // namespace base