Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10162)

Unified Diff: chromecast/media/cdm/browser_cdm_cast.h

Issue 1124073006: Make BrowserCdmCast::Initialize() a virtual function so that a subclass can override the initializa… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Per review comments, create InitializeInternal instead of making Initialize virtual Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/media/cdm/browser_cdm_cast.cc » ('j') | chromecast/media/cdm/browser_cdm_cast.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/cdm/browser_cdm_cast.h
diff --git a/chromecast/media/cdm/browser_cdm_cast.h b/chromecast/media/cdm/browser_cdm_cast.h
index 1f2d8e76b48a78706f700fb7a2f288be436fd4a0..7a83a08dcc84fb3fa637b3d634f5411ef551bb5b 100644
--- a/chromecast/media/cdm/browser_cdm_cast.h
+++ b/chromecast/media/cdm/browser_cdm_cast.h
@@ -77,6 +77,10 @@ class BrowserCdmCast : public ::media::BrowserCdm {
private:
friend class BrowserCdmCastUi;
+ // Allow subclasses to override to provide key sysytem specific
+ // initialization.
+ virtual void InitializeInternal();
gunsch-google 2015/05/15 17:48:27 any particular reason it's private vs. protected?
lcwu1 2015/05/15 18:01:20 If this member doesn't need to be accessed by the
+
::media::SessionMessageCB session_message_cb_;
::media::SessionClosedCB session_closed_cb_;
::media::LegacySessionErrorCB legacy_session_error_cb_;
« no previous file with comments | « no previous file | chromecast/media/cdm/browser_cdm_cast.cc » ('j') | chromecast/media/cdm/browser_cdm_cast.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698