Make BrowserCdmCast::Initialize() a virtual function so that a subclass can override the initializa…

chromecast/media/cdm/browser_cdm_cast.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_MEDIA_CDM_BROWSER_CDM_CAST_H_
 #define CHROMECAST_MEDIA_CDM_BROWSER_CDM_CAST_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 59 matching lines @@
   void OnSessionMessage(const std::string& session_id,
                         const std::vector<uint8_t>& message,
                         const GURL& destination_url);
   void OnSessionClosed(const std::string& session_id);
   void OnSessionKeysChange(const std::string& session_id,
                            const ::media::KeyIdAndKeyPairs& keys);
 
  private:
   friend class BrowserCdmCastUi;
 
+  // Allow subclasses to override to provide key sysytem specific
+  // initialization.
+  virtual void InitializeInternal();

[gunsch-google, 2015/05/15 17:48:27]

any particular reason it's private vs. protected?

[lcwu1, 2015/05/15 18:01:20]

If this member doesn't need to be accessed by the subclasses, it doesn't need to
be 'protected'.

+
   ::media::SessionMessageCB session_message_cb_;
   ::media::SessionClosedCB session_closed_cb_;
   ::media::LegacySessionErrorCB legacy_session_error_cb_;
   ::media::SessionKeysChangeCB session_keys_change_cb_;
   ::media::SessionExpirationUpdateCB session_expiration_update_cb_;
 
   scoped_ptr<::media::PlayerTrackerImpl> player_tracker_impl_;
 
   base::ThreadChecker thread_checker_;
 
@@ skipping 44 matching lines @@
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserCdmCastUi);
 };
 
 }  // namespace media
 }  // namespace chromecast
 
 #endif  // CHROMECAST_MEDIA_CDM_BROWSER_CDM_CAST_H_