Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chromecast/media/cdm/browser_cdm_cast.cc

Issue 1124073006: Make BrowserCdmCast::Initialize() a virtual function so that a subclass can override the initializa… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Per review comments, create InitializeInternal instead of making Initialize virtual Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cdm/browser_cdm_cast.cc
diff --git a/chromecast/media/cdm/browser_cdm_cast.cc b/chromecast/media/cdm/browser_cdm_cast.cc
index 07c3c3e5500e9d5e94d08ffc2ced5aa611543336..0eeeab01470db21142de32cc4828dee6361bd54b 100644
--- a/chromecast/media/cdm/browser_cdm_cast.cc
+++ b/chromecast/media/cdm/browser_cdm_cast.cc
@@ -39,6 +39,8 @@ void BrowserCdmCast::Initialize(
legacy_session_error_cb_ = legacy_session_error_cb;
session_keys_change_cb_ = session_keys_change_cb;
session_expiration_update_cb_ = session_expiration_update_cb;
+
+ InitializeInternal();
}
int BrowserCdmCast::RegisterPlayer(const base::Closure& new_key_cb,
@@ -198,5 +200,10 @@ void BrowserCdmCastUi::RemoveSession(
return nullptr;
}
+// A default empty implementation for subclasses that don't need to any
gunsch-google 2015/05/15 17:48:26 missing a word: "don't need to any"
lcwu1 2015/05/15 18:01:20 Done.
+// key system specific initialization.
gunsch-google 2015/05/15 17:48:27 style nit: method comments go with declaration, no
lcwu1 2015/05/15 18:01:20 There is already a function comment in the declara
+void BrowserCdmCast::InitializeInternal() {
+}
+
} // namespace media
} // namespace chromecast
« chromecast/media/cdm/browser_cdm_cast.h ('K') | « chromecast/media/cdm/browser_cdm_cast.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698