Make BrowserCdmCast::Initialize() a virtual function so that a subclass can override the initializa…

Make BrowserCdmCast::Initialize() a virtual function so that a subclass can override the initialization routine.

BUG=internal b/20222899

Committed: https://crrev.com/4aa4532f0fa4c8f429edbfa4ddd1f24c508f5c6e
Cr-Commit-Position: refs/heads/master@{#330195}

[lcwu1, 2015-05-15 01:53:13]

lcwu@chromium.org changed reviewers:
+ gunsch@chromium.org

[lcwu1, 2015-05-15 01:53:38]

The CQ bit was checked by lcwu@chromium.org to run a CQ dry run

[lcwu1, 2015-05-15 01:53:42]

The CQ bit was unchecked by lcwu@chromium.org

[lcwu1, 2015-05-15 01:56:42]

lcwu@chromium.org changed reviewers:
+ servolk@chromium.org

[gunsch-google, 2015-05-15 06:30:07]

gunsch@google.com changed reviewers:
+ gunsch@google.com

[gunsch-google, 2015-05-15 06:30:08]

See internal review comments as well, but I don't agree with making Initialize
virtual.

[gunsch-google, 2015-05-15 17:48:27]

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
chromecast/media/cdm/browser_cdm_cast.cc:203: // A default empty implementation
for subclasses that don't need to any
missing a word: "don't need to any"

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
chromecast/media/cdm/browser_cdm_cast.cc:204: // key system specific
initialization.
style nit: method comments go with declaration, not definition

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
File chromecast/media/cdm/browser_cdm_cast.h (right):

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
chromecast/media/cdm/browser_cdm_cast.h:82: virtual void InitializeInternal();
any particular reason it's private vs. protected?

[lcwu1, 2015-05-15 18:01:20]

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
chromecast/media/cdm/browser_cdm_cast.cc:203: // A default empty implementation
for subclasses that don't need to any
On 2015/05/15 17:48:26, gunsch-google wrote:
> missing a word: "don't need to any"

Done.

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
chromecast/media/cdm/browser_cdm_cast.cc:204: // key system specific
initialization.
On 2015/05/15 17:48:27, gunsch-google wrote:
> style nit: method comments go with declaration, not definition

There is already a function comment in the declaration. This is a comment
specifically for the implementation.

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
File chromecast/media/cdm/browser_cdm_cast.h (right):

https://codereview.chromium.org/1124073006/diff/20001/chromecast/media/cdm/br...
chromecast/media/cdm/browser_cdm_cast.h:82: virtual void InitializeInternal();
On 2015/05/15 17:48:27, gunsch-google wrote:
> any particular reason it's private vs. protected?

If this member doesn't need to be accessed by the subclasses, it doesn't need to
be 'protected'.

[gunsch-google, 2015-05-15 18:06:09]

lgtm

[lcwu1, 2015-05-15 20:58:56]

The CQ bit was checked by lcwu@chromium.org

[commit-bot: I haz the power, 2015-05-15 21:00:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124073006/40001

[commit-bot: I haz the power, 2015-05-15 21:07:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-18 11:27:27]

Patchset 3 (id:??) landed as
https://crrev.com/4aa4532f0fa4c8f429edbfa4ddd1f24c508f5c6e
Cr-Commit-Position: refs/heads/master@{#330195}