Make BrowserCdmCast::Initialize() a virtual function so that a subclass can override the initializa…

chromecast/media/cdm/browser_cdm_cast.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/cdm/browser_cdm_cast.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "media/base/cdm_key_information.h"
@@ skipping 21 matching lines @@
     const ::media::SessionExpirationUpdateCB& session_expiration_update_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   player_tracker_impl_.reset(new ::media::PlayerTrackerImpl);
 
   session_message_cb_ = session_message_cb;
   session_closed_cb_ = session_closed_cb;
   legacy_session_error_cb_ = legacy_session_error_cb;
   session_keys_change_cb_ = session_keys_change_cb;
   session_expiration_update_cb_ = session_expiration_update_cb;
+
+  InitializeInternal();
 }
 
 int BrowserCdmCast::RegisterPlayer(const base::Closure& new_key_cb,
                                    const base::Closure& cdm_unset_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
   return player_tracker_impl_->RegisterPlayer(new_key_cb, cdm_unset_cb);
 }
 
 void BrowserCdmCast::UnregisterPlayer(int registration_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ skipping 139 matching lines @@
     scoped_ptr<::media::SimpleCdmPromise> promise) {
   DCHECK(thread_checker_.CalledOnValidThread());
   FORWARD_ON_CDM_THREAD(RemoveSession, session_id, base::Passed(&promise));
 }
 
 ::media::CdmContext* BrowserCdmCastUi::GetCdmContext() {
   NOTREACHED();
   return nullptr;
 }
 
+// A default empty implementation for subclasses that don't need to any

[gunsch-google, 2015/05/15 17:48:26]

missing a word: "don't need to any"

[lcwu1, 2015/05/15 18:01:20]

Done.

+// key system specific initialization.

[gunsch-google, 2015/05/15 17:48:27]

style nit: method comments go with declaration, not definition

[lcwu1, 2015/05/15 18:01:20]

There is already a function comment in the declaration. This is a comment
specifically for the implementation.

+void BrowserCdmCast::InitializeInternal() {
+}
+
 }  // namespace media
 }  // namespace chromecast