Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 1123393005: Remove redundant at_read_eof and at_write_eof methods. (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant at_read_eof and at_write_eof methods. Committed: https://crrev.com/37de576c62d934da3eb20da9ad64e2bb347da9a0 Cr-Commit-Position: refs/heads/master@{#330314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -180 lines) Patch
M net/quic/quic_http_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 26 chunks +80 lines, -80 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 3 chunks +2 lines, -11 lines 0 comments Download
M net/socket/socket_test_util.cc View 8 chunks +15 lines, -23 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-16 20:52:35 UTC) #2
ramant (doing other things)
lgtm
5 years, 7 months ago (2015-05-17 04:49:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123393005/1
5 years, 7 months ago (2015-05-17 20:25:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 20:28:27 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:33:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37de576c62d934da3eb20da9ad64e2bb347da9a0
Cr-Commit-Position: refs/heads/master@{#330314}

Powered by Google App Engine
This is Rietveld 408576698