net/quic/quic_http_stream_test.cc - Issue 1123393005: Remove redundant at_read_eof and at_write_eof methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_http_stream_test.cc

Issue 1123393005: Remove redundant at_read_eof and at_write_eof methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_http_stream_test.cc

diff --git a/net/quic/quic_http_stream_test.cc b/net/quic/quic_http_stream_test.cc

index 3e24ccb9c38b6fee6a3f289e6677666d35579bfc..ed42db6ecc3918ace57eb1e782cadb09ac88f239 100644

--- a/net/quic/quic_http_stream_test.cc

+++ b/net/quic/quic_http_stream_test.cc

@@ -162,7 +162,8 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<QuicVersion> {

}

bool AtEof() {

- return socket_data_->at_read_eof() && socket_data_->at_write_eof();

+ return socket_data_->AllReadDataConsumed() &&

+ socket_data_->AllWriteDataConsumed();

}

void ProcessPacket(scoped_ptr<QuicEncryptedPacket> packet) {

« no previous file with comments | « no previous file | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »