Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: net/socket/socket_test_util.h

Issue 1123393005: Remove redundant at_read_eof and at_write_eof methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/sequenced_socket_data_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.h
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index 0148ecdb3be6ade11ecb8f70ce241e7b12aae1ee..3260d6157b0a7229fb9ec4772c5ab8d90658e656 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -265,8 +265,8 @@ class StaticSocketDataHelper {
size_t read_count() const { return read_count_; }
size_t write_count() const { return write_count_; }
- bool at_read_eof() const { return read_index_ >= read_count_; }
- bool at_write_eof() const { return write_index_ >= write_count_; }
+ bool AllReadDataConsumed() const { return read_index_ >= read_count_; }
+ bool AllWriteDataConsumed() const { return write_index_ >= write_count_; }
private:
MockRead* reads_;
@@ -304,9 +304,6 @@ class StaticSocketDataProvider : public SocketDataProvider {
size_t read_count() const { return helper_.read_count(); }
size_t write_count() const { return helper_.write_count(); }
- bool at_read_eof() const { return helper_.at_read_eof(); }
- bool at_write_eof() const { return helper_.at_write_eof(); }
-
protected:
StaticSocketDataHelper* helper() { return &helper_; }
@@ -403,12 +400,6 @@ class SequencedSocketData : public SocketDataProvider {
bool AllReadDataConsumed() const override;
bool AllWriteDataConsumed() const override;
- // Returns true if all data has been read.
- bool at_read_eof() const;
-
- // Returns true if all data has been written.
- bool at_write_eof() const;
-
bool IsReadPaused();
void CompleteRead();
« no previous file with comments | « net/socket/sequenced_socket_data_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698