Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issue 1123373007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in directory src/ui/ (Closed)

Created:
5 years, 7 months ago by d.samantaray
Modified:
5 years, 7 months ago
Reviewers:
sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in directory. src/ui/app_list, ui/ozone,ui/message_center BUG=457697 Committed: https://crrev.com/8022c2fcb6edd10c1f38b8962ec398bc853bb4ae Cr-Commit-Position: refs/heads/master@{#331069}

Patch Set 1 #

Patch Set 2 : clean up in ui/app_list, ui/ozone, ui/message_center directories #

Total comments: 2

Patch Set 3 : Addressed the review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ui/app_list/search_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
d.samantaray
Uploaded the patch.https://codereview.chromium.org/1123373007 Please review.
5 years, 7 months ago (2015-05-15 04:28:08 UTC) #2
vabr (Chromium)
Please choose appropriate OWNERS reviewers (https://www.chromium.org/developers/owners-files).
5 years, 7 months ago (2015-05-15 08:23:58 UTC) #3
d.samantaray
I have uploaded the patch. Please review. https://codereview.chromium.org/1123373007
5 years, 7 months ago (2015-05-15 08:48:00 UTC) #5
d.samantaray
Incorporated the changes please review.
5 years, 7 months ago (2015-05-21 12:22:37 UTC) #9
sadrul
lgtm https://codereview.chromium.org/1123373007/diff/40001/ui/app_list/search_controller.cc File ui/app_list/search_controller.cc (right): https://codereview.chromium.org/1123373007/diff/40001/ui/app_list/search_controller.cc#newcode125 ui/app_list/search_controller.cc:125: providers_.push_back(provider.Pass()); // Takes ownership. Remove the comment at ...
5 years, 7 months ago (2015-05-21 14:44:54 UTC) #11
d.samantaray
Addressed and incorporated the review comments. Please have a look. https://codereview.chromium.org/1123373007/diff/40001/ui/app_list/search_controller.cc File ui/app_list/search_controller.cc (right): https://codereview.chromium.org/1123373007/diff/40001/ui/app_list/search_controller.cc#newcode125 ...
5 years, 7 months ago (2015-05-22 03:37:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123373007/60001
5 years, 7 months ago (2015-05-22 04:55:32 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-22 05:51:48 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 05:52:36 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8022c2fcb6edd10c1f38b8962ec398bc853bb4ae
Cr-Commit-Position: refs/heads/master@{#331069}

Powered by Google App Engine
This is Rietveld 408576698