Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/app_list/search_controller.cc

Issue 1123373007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in directory src/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed the review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/app_list/search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/search_controller.cc
diff --git a/ui/app_list/search_controller.cc b/ui/app_list/search_controller.cc
index d0ee2ab36fe294e132c97f097dd5ff55cdbc0d41..f0a21fa76cb99194ff0fe513844cde9e5a1d9f7a 100644
--- a/ui/app_list/search_controller.cc
+++ b/ui/app_list/search_controller.cc
@@ -122,7 +122,7 @@ void SearchController::AddProvider(size_t group_id,
&SearchController::OnResultsChanged,
base::Unretained(this)));
mixer_->AddProviderToGroup(group_id, provider.get());
- providers_.push_back(provider.release()); // Takes ownership.
+ providers_.push_back(provider.Pass());
}
void SearchController::OnResultsChanged() {
« no previous file with comments | « no previous file | ui/app_list/search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698