Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 11229007: Revert "Use WebRenderingStats::Enumerate to populate benchmarking extension renderingStats() fields… (Closed)

Created:
8 years, 2 months ago by brianderson
Modified:
8 years, 2 months ago
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Revert "Use WebRenderingStats::Enumerate to populate benchmarking extension renderingStats() fields." BUG=156851 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163128

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add numImplThreadScrolls and numMainThreadScrolls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -52 lines) Patch
M content/common/gpu/gpu_rendering_stats.h View 1 chunk +0 lines, -24 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 chunks +38 lines, -28 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
brianderson
8 years, 2 months ago (2012-10-19 17:59:03 UTC) #1
brianderson
https://codereview.chromium.org/11229007/diff/1/content/renderer/gpu/gpu_benchmarking_extension.cc File content/renderer/gpu/gpu_benchmarking_extension.cc (right): https://codereview.chromium.org/11229007/diff/1/content/renderer/gpu/gpu_benchmarking_extension.cc#newcode187 content/renderer/gpu/gpu_benchmarking_extension.cc:187: v8::Integer::New(stats.totalCommitCount)); A straight up revert compiles, but leaves out ...
8 years, 2 months ago (2012-10-19 18:54:30 UTC) #2
dtu
lgtm lgtm
8 years, 2 months ago (2012-10-19 19:09:06 UTC) #3
jamesr
lgtm2
8 years, 2 months ago (2012-10-19 19:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/11229007/5001
8 years, 2 months ago (2012-10-19 20:00:36 UTC) #5
commit-bot: I haz the power
Presubmit check for 11229007-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-19 20:00:39 UTC) #6
brianderson
Adding apatrick to review content/renderer/gpu changes.
8 years, 2 months ago (2012-10-19 20:02:57 UTC) #7
brianderson
Al is on vacation, adding Ken for OWNER's review instead.
8 years, 2 months ago (2012-10-19 20:27:35 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
8 years, 2 months ago (2012-10-19 21:35:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/11229007/5001
8 years, 2 months ago (2012-10-19 21:36:27 UTC) #10
commit-bot: I haz the power
Retried try job too often for step(s) sync_integration_tests
8 years, 2 months ago (2012-10-19 22:54:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/11229007/5001
8 years, 2 months ago (2012-10-20 00:18:24 UTC) #12
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 02:08:03 UTC) #13
Change committed as 163128

Powered by Google App Engine
This is Rietveld 408576698