Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: content/renderer/gpu/gpu_benchmarking_extension.cc

Issue 11229007: Revert "Use WebRenderingStats::Enumerate to populate benchmarking extension renderingStats() fields… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Add numImplThreadScrolls and numMainThreadScrolls Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/gpu/gpu_rendering_stats.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/gpu_benchmarking_extension.h" 5 #include "content/renderer/gpu/gpu_benchmarking_extension.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 DCHECK(file.isValid()); 74 DCHECK(file.isValid());
75 picture_.serialize(&file); 75 picture_.serialize(&file);
76 } 76 }
77 77
78 private: 78 private:
79 FilePath dirpath_; 79 FilePath dirpath_;
80 int layer_id_; 80 int layer_id_;
81 SkPicture picture_; 81 SkPicture picture_;
82 }; 82 };
83 83
84 class RenderingStatsEnumerator
85 : public WebRenderingStats::Enumerator,
86 public content::GpuRenderingStats::Enumerator {
87 public:
88 RenderingStatsEnumerator(v8::Handle<v8::Object> stats_object)
89 : stats_object_(stats_object) { }
90
91 virtual void addInt(const char* name, int value) {
92 stats_object_->Set(v8::String::New(name), v8::Integer::New(value));
93 }
94
95 virtual void addDouble(const char* name, double value) {
96 stats_object_->Set(v8::String::New(name), v8::Number::New(value));
97 }
98
99 virtual void addTimeDelta(const char* name, base::TimeDelta value) {
100 stats_object_->Set(v8::String::New(name),
101 v8::Number::New(value.InSecondsF()));
102 }
103
104 private:
105 v8::Handle<v8::Object> stats_object_;
106 };
107
108 } // namespace 84 } // namespace
109 85
110 namespace content { 86 namespace content {
111 87
112 class GpuBenchmarkingWrapper : public v8::Extension { 88 class GpuBenchmarkingWrapper : public v8::Extension {
113 public: 89 public:
114 GpuBenchmarkingWrapper() : 90 GpuBenchmarkingWrapper() :
115 v8::Extension(kGpuBenchmarkingExtensionName, 91 v8::Extension(kGpuBenchmarkingExtensionName,
116 "if (typeof(chrome) == 'undefined') {" 92 "if (typeof(chrome) == 'undefined') {"
117 " chrome = {};" 93 " chrome = {};"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 163
188 RenderViewImpl* render_view_impl = RenderViewImpl::FromWebView(web_view); 164 RenderViewImpl* render_view_impl = RenderViewImpl::FromWebView(web_view);
189 if (!render_view_impl) 165 if (!render_view_impl)
190 return v8::Undefined(); 166 return v8::Undefined();
191 167
192 WebRenderingStats stats; 168 WebRenderingStats stats;
193 render_view_impl->GetRenderingStats(stats); 169 render_view_impl->GetRenderingStats(stats);
194 170
195 content::GpuRenderingStats gpu_stats; 171 content::GpuRenderingStats gpu_stats;
196 render_view_impl->GetGpuRenderingStats(&gpu_stats); 172 render_view_impl->GetGpuRenderingStats(&gpu_stats);
173 v8::Handle<v8::Object> stats_object = v8::Object::New();
174 stats_object->Set(v8::String::New("numAnimationFrames"),
175 v8::Integer::New(stats.numAnimationFrames));
176 stats_object->Set(v8::String::New("numFramesSentToScreen"),
177 v8::Integer::New(stats.numFramesSentToScreen));
178 stats_object->Set(v8::String::New("droppedFrameCount"),
179 v8::Integer::New(stats.droppedFrameCount));
180 stats_object->Set(v8::String::New("totalPaintTimeInSeconds"),
181 v8::Number::New(stats.totalPaintTimeInSeconds));
182 stats_object->Set(v8::String::New("totalRasterizeTimeInSeconds"),
183 v8::Number::New(stats.totalRasterizeTimeInSeconds));
184 stats_object->Set(v8::String::New("totalCommitTimeInSeconds"),
185 v8::Number::New(stats.totalCommitTimeInSeconds));
186 stats_object->Set(v8::String::New("totalCommitCount"),
187 v8::Integer::New(stats.totalCommitCount));
188 stats_object->Set(v8::String::New("numImplThreadScrolls"),
189 v8::Integer::New(stats.numImplThreadScrolls));
190 stats_object->Set(v8::String::New("numMainThreadScrolls"),
191 v8::Integer::New(stats.numMainThreadScrolls));
197 192
198 v8::Handle<v8::Object> stats_object = v8::Object::New(); 193 stats_object->Set(v8::String::New("globalTextureUploadCount"),
199 RenderingStatsEnumerator enumerator(stats_object); 194 v8::Number::New(gpu_stats.global_texture_upload_count));
200 stats.enumerateFields(&enumerator); 195 stats_object->Set(
201 gpu_stats.enumerateFields(&enumerator); 196 v8::String::New("globalTotalTextureUploadTimeInSeconds"),
197 v8::Number::New(
198 gpu_stats.global_total_texture_upload_time.InSecondsF()));
199 stats_object->Set(v8::String::New("textureUploadCount"),
200 v8::Number::New(gpu_stats.texture_upload_count));
201 stats_object->Set(
202 v8::String::New("totalTextureUploadTimeInSeconds"),
203 v8::Number::New(gpu_stats.total_texture_upload_time.InSecondsF()));
204 stats_object->Set(
205 v8::String::New("globalTotalProcessingCommandsTimeInSeconds"),
206 v8::Number::New(
207 gpu_stats.global_total_processing_commands_time.InSecondsF()));
208 stats_object->Set(
209 v8::String::New("totalProcessingCommandsTimeInSeconds"),
210 v8::Number::New(
211 gpu_stats.total_processing_commands_time.InSecondsF()));
202 return stats_object; 212 return stats_object;
203 } 213 }
204 214
205 static v8::Handle<v8::Value> PrintToSkPicture(const v8::Arguments& args) { 215 static v8::Handle<v8::Value> PrintToSkPicture(const v8::Arguments& args) {
206 if (args.Length() != 1) 216 if (args.Length() != 1)
207 return v8::Undefined(); 217 return v8::Undefined();
208 218
209 v8::String::AsciiValue dirname(args[0]); 219 v8::String::AsciiValue dirname(args[0]);
210 if (dirname.length() == 0) 220 if (dirname.length() == 0)
211 return v8::Undefined(); 221 return v8::Undefined();
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 383
374 return results; 384 return results;
375 } 385 }
376 }; 386 };
377 387
378 v8::Extension* GpuBenchmarkingExtension::Get() { 388 v8::Extension* GpuBenchmarkingExtension::Get() {
379 return new GpuBenchmarkingWrapper(); 389 return new GpuBenchmarkingWrapper();
380 } 390 }
381 391
382 } // namespace content 392 } // namespace content
OLDNEW
« no previous file with comments | « content/common/gpu/gpu_rendering_stats.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698